yangmillstheory / vim-snipe

MIT License
118 stars 8 forks source link

Using a motion should not alter the buffer's "modified" state #9

Closed Vadskye closed 6 years ago

Vadskye commented 6 years ago

Expected behavior: If I use a motion in an unmodified buffer, the buffer should still be considered unmodified after the motion is finished.

Current behavior: If I use a motion in an unmodified buffer, the buffer is considered to be "modified" after the motion is finished.

yangmillstheory commented 6 years ago

OK, this shouldn't apply to snipe-*-x, snipe-*-xp, snipe-*-r, since those write to the buffer, but everything else.

What are the consequences of the buffer being "modified"?

Vadskye commented 6 years ago

Ah, yes, thanks - this is only a bug when referring to the "motion-only" commands.

The main consequence I notice is that I get warnings when I try to close the buffer window (because Vim thinks I'm about to lose unsaved changes).

yangmillstheory commented 6 years ago

Thoughts on 19eb793?

Vadskye commented 6 years ago

LGTM