search

yanne / api-test

0 stars 0 forks source link

New keywords for getting and putting whole directories #66

Closed yanne closed 10 years ago

yanne commented 10 years ago

We need to copy multiple files from one server to another server using ssh connection.

Currently we have "Put file" for putting single file from one server to another. Similar, we need a keyword for copying multiple files or a directory. Can you please help us in this regard?

This issue was originally opened at Google Code on Apr 26, 2013.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Jul 25, 2013.

This seems to be a common need. Implementing.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Aug 2, 2013.

This should be done by https://code.google.com/p/robotframework-sshlibrary/source/detail?r=d920bc6aa286115be97960eedd8ab0a0c87465fe .

Please verify that this fulfills your requirements.

yanne commented 10 years ago

Original comment by pekka.klarck on Oct 24, 2013.

While reviewing the code we noticed that the current implementation works only with directories in the remote working directory. This needs to be fixed and tests changed so that they find this problem.

We also noticed few other things that can be enhanced. These both need their own issues:

1) Try to get rid of path_separator argument. Either detect the remote path separator automatically or make it configurable globally and per connection. This applies also to the existing Get/Put File keywords, but with them the argument needs to be only deprecated at this point.

2) Change all Get/Put File/Directory keywords to return moved files as a list of tuples, not as two separate lists.

yanne commented 10 years ago

Original comment by muden...@gmail.com on Nov 10, 2013.

I just trying the new Keyword “SSHLibrary.Put Directory”，and found it does not put empty directory to remote host.

Please fix it, Because 1.2 not release yet, so I'm not file this bug.

yanne commented 10 years ago

Original comment by jussi.ao...@gmail.com on Nov 13, 2013.

This issue was updated by revision 35cc8433d28d .

yanne commented 10 years ago

Original comment by jussi.ao...@gmail.com on Nov 13, 2013.

This issue was updated by revision afb30c965a6d .

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 14, 2013.

This issue was updated by revision f81611e3ec50 .

Tidied up tests for Get Directory.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 14, 2013.

This issue was updated by revision 70f3dc037981 .

Refactored Put Directory implementation and tests.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 19, 2013.

This issue was updated by revision ef0208404d98 .

Refactored Put Directory implementation to use our own recursion instead of using os.walk().

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 19, 2013.

This issue was updated by revision 44be681eb565 .

Put Directory now uploads empty directories as well.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 19, 2013.

This issue was updated by revision 499410b717e6 .

Also, Get Directory now downloads empty directories.