search

yanqiyqh / pe

0 stars 0 forks source link

Allow invalid characters like + in h/ #9

Open yanqiyqh opened 2 weeks ago

yanqiyqh commented 2 weeks ago

lesson add sid/1 f/10 d/23-10-2024 16:00 h/+1 results in a successful lesson add. This should be flagged as an invalid duration because of the +.

Screenshot 2024-11-15 at 5.34.03 PM.png

nus-pe-script commented 1 week ago

Team's Response

Thank you for raising this concern.

This is allowed as DURATION accepts any positive integer or decimal number in multiples of 0.5, more than 0 and at most 24. In the specific test case of using +, +1 has the same value of 1, as it is a positive integer and is a valid input. Therefore, we have concur to reject this issue. Thank you.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]