yarbsemaj / sveltekit-adapter-lambda

An adapter to build a SvelteKit app into a lambda ready for deployment with lambda proxy via the Serverless Framework or CDK.
https://www.npmjs.com/package/@yarbsemaj/adapter-lambda
MIT License
77 stars 16 forks source link

Windows File Path Fix #13

Closed nboehret closed 2 years ago

nboehret commented 2 years ago

This fix allows for a windows machine to build the adapter and for it to run properly on non-windows servers which the majority of cloud systems run as.

I tested this locally on my windows machine and it worked with build, preview, and serverless deploy and they all worked fine.

I understand if no one else cares for this, my own plan is to use CICD for my deployments and that would be from a linux VM of some sort but at least for now this would help me and possibly others.

Related issue: https://github.com/yarbsemaj/sveltekit-adapter-lambda/issues/12

yarbsemaj commented 2 years ago

Hi @nboehret Thank You for your interest in my project! Iv reviewed your PR and think there may be a cleaner way of going about what your trying to do. Could you take a look and see if my suggestions work. :)

nboehret commented 2 years ago

@yarbsemaj You were right! I was looking for something like this but I missed it originally, thank you. This is much simpler and cleaner, imo. Let me know what you think.

nboehret commented 2 years ago

@yarbsemaj any chance we could get a new release?

yarbsemaj commented 2 years ago

@nboehret Iv published a new release, 0.9.2, with your change in :)