Closed NickleDave closed 2 years ago
Also, these issues are what's preventing me from testing whether the fix for newer versions of torch
works. Hence the need to fix sooner rather than later
I ended up solving this differently.
yarden2annot
and added that directly to crowsetta
, and then released a new version of crowsetta
; because I was running into issues with circular imports trying to keep the yarden2annot
module in, and the other workarounds I came up with would have been weird and fragile. Also because we want it to be easy for people to be able to work with those annotations, without needing to install tweetynet necessarilytweetynet/src
repo at the same level -- this is the "package" that this repo can be used to buildarticle
folder and just move all related things into that folder. It will be easy to install but it's not set up to build into a distribution package, which is fineflit
to develop -- the pyproject.toml is the standard used by more projects and I find it much more readable than setup.cfg so I would rather use it
the current source code layout that we've evolved into since 0.6.0 release + setup.py causes a couple of issues:
article
package that I added insrc
is getting added to the source distribution, because thesetup.py
file says "just include every package you find in thesrc/
directory"pip install .[article]
to get dependencies likesklearn
that are declared in theEXTRAS_REQUIRE
of thesetup.py
$ python setup.py sdist
and thenpip install
the generated tar.gz in thedist/
directory, then launch a REPL and try toimport tweetynet
article
package is not to be in thetweetynet
distribution -- it just gives us a separate convenient package to work with for article-only codeyarden2annot
module is currently in thatarticle
package.vak
needs access to it, to load the canary annotations.setup.py
which is not even well-documented any more on thesetuptools
sitefix:
poetry
and usepyproject.toml
yarden2annot
intotweetynet
packageformat
still gets installed forvak
article
code -- we shouldn't putarticle
on PyPI but we should make it easy for an interested reader to install locally. Have a separate README in the "article" sub-directory for thisThis is the structure I mean by "monorepo", I think this is the least-complicated solution. An alternative might be doing something fancy with setup.cfg and/or setup.py but I'm not sure if it's possible and if so worth it