search

yargalot / gulp-accessibility

Gulp plugin for AccessSniff
48 stars 12 forks source link

HTML_CodeSniffer is installed via git@ protocol instead of https #15

Closed kenorb closed 6 years ago

kenorb commented 8 years ago

This happens when installing:

"gulp-accessibility": "2.0.1",
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99: Initialized empty Git repository in /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99/
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99:
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99: Permission denied (publickey).
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99: fatal: The remote end hung up unexpectedly

How do I change that (protocol from where it's installed)? So https instead of ssh.

Full log:

[vagrant@npm]$ npm install gulp-accessibility
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99: Initialized empty Git repository in /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99/
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99:
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99: Permission denied (publickey).
npm ERR! git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99: fatal: The remote end hung up unexpectedly
npm ERR! Linux 2.6.32-642.1.1.el6.x86_64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install" "gulp-accessibility"
npm ERR! node v4.5.0
npm ERR! npm  v2.15.9
npm ERR! code 128

npm ERR! Command failed: git clone --template=/home/vagrant/.npm/_git-remotes/_templates --mirror git@github.com:squizlabs/HTML_CodeSniffer.git /home/vagrant/.npm/_git-remotes/git-github-com-squizlabs-HTML-CodeSniffer-git-65c00b99
npm ERR! Permission denied (publickey).
npm ERR! fatal: The remote end hung up unexpectedly
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /home/vagrant/npm-debug.log

This happens in VM which doesn't have any ssh keys setup, so I would expect it to work.

So I guess cloning via SSH should be changed to HTTPS, e.g. git@ to https://.

yargalot commented 7 years ago

Yeh at the moment I pull in the HTML codesniffer repo from git. I'll have a look and see if I can change that around

gaheinrichs commented 7 years ago

+1

prantlf commented 6 years ago

Fixed by a similar issue in AccessSniff, PR 44, including the upgrade to 2.1.1 and dependency on an NPM module instead of the Github commit tag.

Before this makes it to upstream, I published an alternative module including this feature and upgraded dependencies - gulp-accessibility-ext. Unfortunately, the AccessSniff module needs a compilation step before publishing and it is not possible to depend on a forked Github branch.

prantlf commented 6 years ago

Thanks a lot for the quick merging! I didn't expect, that you'd be quick as a lightning :-) Now I have to to deprecate my gulp-accessibility-ext and grunt-accessibility-ext :'-{ Well, they gained be a green build at work for a day or two, which I needed desperately.

yargalot commented 6 years ago

Hah no probs, Priority goes to getting the prs in. Thanks for helping improve the codebase!