search

yaronzz / Tidal-Media-Downloader

Download 'TIDAL' Music On Windows/Linux/MacOs (PYTHON/C#)
http://doc.yaronzz.com/post/tidal_dl_installation/
Apache License 2.0
3.47k stars 476 forks source link

[QUESTION]: Why this cumbersome refactoring? #1122

Open exislow opened 1 year ago

exislow commented 1 year ago

Which tool

TIDAL-DL

Describe your question

@yaronzz: I have got you some questions about this commit: https://github.com/yaronzz/Tidal-Media-Downloader/commit/8352f0f6e23ac2cf96fc25b26bab7dce2d75cfa1

Would be glad to get a discussion on this.

I would like to create some more pull requests, since I like to actively develop this tool. But you make this really hard...

Add screenshots

No response

exislow commented 11 months ago

No worries, mate. I have started the re-development and already released a first version: https://github.com/exislow/tidal-dl-ng

Code base is way cleaner and leaner. Contribution is way easier and code runs faster. It is under frequent development. I have already built in exclusive new features and expect to have a stable and fully featured code base next week. I will also push it to PyPi afterwards.

Notorious2Beat commented 11 months ago

No worries, mate. I have started the re-development and already released a first version: https://github.com/exislow/tidal-dl-ng

Code base is way cleaner and leaner. Contribution is way easier and code runs faster. It is under frequent development. I expect to have a stable and fully featured code base next week. I will also push it to PyPi afterwards.

Is the another tidal-dl for termux?

exislow commented 11 months ago

Since I replaced the uncomfortable interactive CLI interface with a click based cli interface you can use it with termux now.

Notorious2Beat commented 11 months ago

Since I replaced the uncomfortable interactive CLI interface with a click based cli interface you can use it with termux now.

How can I install for termux?

JosefAschauer commented 11 months ago

Many thanks exislow - how can I run this in python 3.12 / windows? What prerequisites do I need? Any quick docs on this?

exislow commented 11 months ago

Since I replaced the uncomfortable interactive CLI interface with a click based cli interface you can use it with termux now.

How can I install for termux?

It will be possible via. pip as soon as I have a stable build.

Many thanks exislow - how can I run this in python 3.12 / windows? What prerequisites do I need? Any quick docs on this?

Simply run python3 tidal_dl_ng/cli.py --help. I will soon have a full featured README.md.

Could you all do me a favor and open new issues here? https://github.com/exislow/tidal-dl-ng/issues

bjg83 commented 11 months ago

Hey, just tried this but got a virus warning from Windows Defender image Can you clarify if this code is clean? I know Defender can give false positives...

Cheers.

grizzlio commented 11 months ago

Is a false positive. Software are clean.