search

yasuflatland-lf / damascus

⚔️ CRUD boilerplate generator for Liferay DXP
https://yasuflatland-lf.github.io/damascus-doc/
GNU Lesser General Public License v3.0
50 stars 35 forks source link

Some updates to master branch for liferay 7.0 only #69

Closed szacchino closed 5 years ago

szacchino commented 5 years ago

In this fork you'll find:

1) extended support for Language.properties file for english and italian 2) the master branch assetrenderer::getUrlViewInContext() generates URLs of type "/c/find_entry" that required user to login even if it is a guest having view permissions on entities (this happens when searching entities using portal search or an asset publisher); I replaced that code to generate simple renderUrls and added code to check permissions; if the user hasn't permission an exception is thrown. KNOWN TODO: when display entity list in view.jsp, check view permissions and hide entities without view permission for current user; 3) replaced liferay 6.* icons with lexicon ones; 4) replaced - OR - string with liferay localizable message;

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 80.162% when pulling 4e82d0b5f92c4c01809706e7acb261650f04979d on szacchino:master into f1b8064ec6dbb912820df26ad620088aed2b2d35 on yasuflatland-lf:master.

yasuflatland-lf commented 5 years ago

@szacchino , thank you for your great contribution! Let me take a look and do some manual testing on my side, then I`ll marge this PR!

szacchino commented 5 years ago

I've also coded the view.jsp templates to show only entries with proper permissions. I think i'll commit on monday. Thank you.

szacchino commented 5 years ago

I've added also some updates on view.jsp template to show entries only if user has proper permissions.

yasuflatland-lf commented 5 years ago

@szacchino Thank you for your contribution!