search

yathit / ydn-db

Javascript database module for Indexeddb, Web SQL and localStorage storage mechanisms supporting version migration, advanced query, SQL and transaction.
Apache License 2.0
503 stars 41 forks source link

Default query limit not documented #80

Closed cdaringe closed 8 years ago

cdaringe commented 8 years ago

Hello!

I must start by saying thank you!

Here, there's a default query limit being applied: https://github.com/yathit/ydn-db/blob/master/src/ydn/db/query/query.js#L211

However, here: https://dev.yathit.com/api/ydn/db/query.html , it states that query limit is optional. This was unknowingly restricting my query! Although limit is optional I felt a mention of the implicitly applied limit would be beneficial.

Thanks!

:)

yathit commented 8 years ago

Thanks. I have updated the doc.

That is the most surprise about ydn-db api. I really don't like surprise, but thinks that always having a limit on query is a good practice.