Improve code base - Githubissues

yatish27 / linkedin-scraper

Scrapes the public profile of the linkedin page

MIT License

555 stars 220 forks source link

Open w8m8 opened 8 years ago

w8m8 commented 8 years ago

Changed double quotes to single unless interpolation or special symbols are used in string
Rename methods prefixed with get (as all method essentially get something) to find
Use new Ruby (> v1.9) hash syntax
Swap out gsub with tr when there’s no regular expression for performance
Remove parenthesis for method calls with no argument

w8m8 commented 8 years ago

The reason why it fails with Travis appears to be an issue with the bundler and the configuration, rather than the code, so should be problem free.

oskarlakner commented 8 years ago

@yatish27