search

ycba-cia / blacklight-collections2

5 stars 2 forks source link

RBMS images coming from Amazon #372

Closed edgartdata closed 2 years ago

edgartdata commented 2 years ago

Some masonry images for RBMS items are coming from Amazon, such as https://collections.britishart.yale.edu/?utf8=%E2%9C%93&search_field=all_fields&q=%22Outside+your+window+%3A+a+first+book+of+nature+%2F+Nicola+Davies+%3B+illustrated+by+Mark+Hearld.%22

However, this specific RBMS item has no YCBA generated images: https://collections.britishart.yale.edu/catalog/orbis:13205735

RBMS is discussing if they want to keep this behavior for RBMS.

Kraig mentions that fetching Amazon images on the fly for Reference Library items is great for this department.

flapka commented 2 years ago

Upon further discussion, RBM would like to suppress those thumbnails -- if we can do so while keeping the thumbnails that appear for Ref.

yulgit1 commented 2 years ago

Resolved 5/19:

https://github.com/ycba-cia/blacklight-collections2/commit/d6395523e957b6048c6263f3239a607471594a77

edgartdata commented 2 years ago

@flapka @KraigBinkowski Can you test a few records and tell us if we can close this issue?

flapka commented 2 years ago

I've reviewed RBM and Ref masonry results. Everything looks as desired. I think we can close it.

KraigBinkowski commented 2 years ago

I can still see thumbnail images for Ref so it seems fine.

edgartdata commented 2 years ago

Thanks all.