ydb-platform / ydb

YDB is an open source Distributed SQL Database that combines high availability and scalability with strong consistency and ACID transactions
https://ydb.tech
Apache License 2.0
4k stars 565 forks source link

unused-parameter handling differs in main vs stable-24.3 #7045

Closed zverevgeny closed 3 months ago

zverevgeny commented 3 months ago

https://t.me/c/2018419243/1/9327

command /home/runner/.ya/tools/v4/6495238978/bin/clang++ --target=x86_64-linux-gnu --sysroot=/home/runner/.ya/tools/v4/1966560555 -B/home/runner/.ya/tools/v4/1966560555/usr/bin -c -o /home/runner/.ya/build/build_root/uc3q/00269b/ydb/core/tx/columnshard/engines/storage/actualizer/tiering/tiering.cpp.o -I/home/runner/.ya/build/build_root/uc3q/00269b -I/home/runner/actions_runner/_work/ydb/ydb -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/linux-headers -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/linux-headers/_nf -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/cxxsupp/libcxx/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/cxxsupp/libcxxrt/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/clang16-rt/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/zlib/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/double-conversion -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libc_compat/include/readpassphrase -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libc_compat/reallocarray -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libc_compat/random -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/abseil-cpp -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/tcmalloc -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libiconv/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/protobuf/src -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/grpc/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/c-ares/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/openssl/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/re2/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/abseil-cpp-tstring -I/home/runner/.ya/build/build_root/uc3q/00269b/library/cpp/build_info -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libidn/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/brotli/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/snappy/include -I/home/runner/.ya/build/build_root/uc3q/00269b/contrib/libs/apache/arrow/cpp/src -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/apache/arrow/cpp/src -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/apache/arrow/src -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/apache/orc/c++/include -I/home/runner/.ya/build/build_root/uc3q/00269b/contrib/libs/apache/orc-format/src/main/proto/orc/proto -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/thrift -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libevent/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/interprocess/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/assert/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/config/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/container/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/intrusive/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/container_hash/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/describe/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/mp11/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/move/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/static_assert/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/core/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/throw_exception/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/integer/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/type_traits/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/unordered/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/detail/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/preprocessor/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/predef/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/smart_ptr/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/tuple/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/winapi/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/locale/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/icu/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/iterator/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/concept_check/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/function_types/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/mpl/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/utility/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/io/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/fusion/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/functional/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/function/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/bind/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/typeof/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/optional/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/thread/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/atomic/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/align/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/chrono/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/ratio/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/system/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/variant2/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/date_time/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/algorithm/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/array/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/exception/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/range/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/conversion/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/regex/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/lexical_cast/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/numeric_conversion/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/tokenizer/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/math/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/random/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/boost/dynamic_bitset/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/restricted/uriparser/include -I/home/runner/.ya/build/build_root/uc3q/00269b/contrib/libs/opentelemetry-proto -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/libaio/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/liburing/src/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/cctz/include -I/home/runner/actions_runner/_work/ydb/ydb/contrib/libs/sparsehash/src -fdebug-prefix-map=/home/runner/.ya/build/build_root/uc3q/00269b=/-B -fdebug-prefix-map=/home/runner/actions_runner/_work/ydb/ydb=/-S -fdebug-prefix-map=/home/runner/.ya/tools/v4=/-T -Xclang -fdebug-compilation-dir -Xclang /tmp -pipe -m64 -O3 -g -ggnu-pubnames -fexceptions -fno-common -ffunction-sections -fdata-sections -fuse-init-array -fcolor-diagnostics -faligned-allocation -fdebug-default-version=4 -Wall -Wextra -Wno-parentheses -Wno-implicit-const-int-float-conversion -Wno-unknown-warning-option -Werror -DARCADIA_ROOT=/home/runner/actions_runner/_work/ydb/ydb -DARCADIA_BUILD_ROOT=/home/runner/.ya/build/build_root/uc3q/00269b -D_THREAD_SAFE -D_PTHREADS -D_REENTRANT -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_YNDX_LIBUNWIND_ENABLE_EXCEPTION_BACKTRACE -UNDEBUG -D__LONG_LONG_SUPPORTED -DSSE_ENABLED=1 -DSSE3_ENABLED=1 -DSSSE3_ENABLED=1 -DSSE41_ENABLED=1 -DSSE42_ENABLED=1 -DPOPCNT_ENABLED=1 -DCX16_ENABLED=1 -fno-omit-frame-pointer -D_libunwind_ -DLIBCXX_BUILDING_LIBCXXRT -DCARES_STATICLIB -DBOOST_ALL_NO_LIB -DBOOST_THREAD_USE_LIB -DBOOST_THREAD_POSIX -DARROW_STATIC -DPARQUET_STATIC -Wno-array-parameter -Wno-deprecate-lax-vec-conv-all -Wno-unqualified-std-cast-call -Wno-unused-but-set-parameter -Wno-implicit-function-declaration -Wno-int-conversion -Wno-incompatible-function-pointer-types -Wno-address-of-packed-member -DCATBOOST_OPENSOURCE=yes -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mpopcnt -mcx16 -Wno-array-parameter -Wno-deprecate-lax-vec-conv-all -Wno-unqualified-std-cast-call -Wno-unused-but-set-parameter -Wno-implicit-function-declaration -Wno-int-conversion -Wno-incompatible-function-pointer-types -Wno-address-of-packed-member -std=c++20 -Woverloaded-virtual -Wimport-preprocessor-directive-pedantic -Wno-ambiguous-reversed-operator -Wno-defaulted-function-deleted -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-enum-float-conversion -Wno-deprecated-volatile -Wno-pessimizing-move -Wno-return-std-move -Wno-undefined-var-template -nostdinc++ -DCATBOOST_OPENSOURCE=yes -nostdinc++ /home/runner/actions_runner/_work/ydb/ydb/ydb/core/tx/columnshard/engines/storage/actualizer/tiering/tiering.cpp failed with exit code 1 in /home/runner/.ya/build/build_root/uc3q/00269b
In file included from /home/runner/actions_runner/_work/ydb/ydb/ydb/core/tx/columnshard/engines/storage/actualizer/tiering/tiering.cpp:4:
/home/runner/actions_runner/_work/ydb/ydb/ydb/core/tx/columnshard/engines/storage/indexes/max/meta.h:14:82: error: unused parameter 'newMeta' [-Werror,-Wunused-parameter]
    virtual TConclusionStatus DoCheckModificationCompatibility(const IIndexMeta& newMeta) const override {

У меня сборка PR в 24.3 упала с unused parameter: https://storage.yandexcloud.net/ydb-gh-logs/ydb-platform/ydb/PR-check/10063562427/ya-x86-64/build_logs/ya_make.log, а в main этот же самый код не приводит к ошибке. Разные опции компилятора?

maximyurchuk commented 3 months ago

Это все протобуф https://github.com/protocolbuffers/protobuf/commit/8aff59e1c48dc2ed7e53cff40b21515a4d562e67 Коллеги чинят: DTCC-2275