Add a view menu with zoom actions

yds12 / tarsila

Pixel art and spritesheet editor

Other

141 stars 7 forks source link

Add a view menu with zoom actions #16

Closed crumblingstatue closed 1 year ago

crumblingstatue commented 1 year ago

Add the following actions:

Zoom in/out via menu (discoverability)
Reset zoom to default (800% currently)
Set zoom to 100%

crumblingstatue commented 1 year ago

More ideas:

Show shortcut keys for the menu items (see Button::shortcut_text) This would require making the shortcut data available to the menu function
For the reset zoom, inform the user of the value we are resetting to via hover This would require making the default zoom data available to the menu function

yds12 commented 1 year ago

Thanks for taking the time to implement this very useful feature.

I like the proposals to show the shortcuts in the menu items as well, I'd welcome other PRs doing this. The hover with extra information about the default zoom is also great. Please see my comment in the PR code -- with that approach we also don't need to pass any information (for now, this will change later) to the menu, we can just access the constant.

yds12 commented 1 year ago

Linking the preferences discussion thread: https://github.com/yds12/tarsila/discussions/17

yds12 commented 1 year ago

Thank you! Merging