Adding third import option for nodes.csv

yeatmanlab / AFQ-Browser

Browser-based visualization tools for AFQ results

BSD 3-Clause "New" or "Revised" License

33 stars 15 forks source link

Adding third import option for nodes.csv #287

Closed bloomdt-uw closed 3 years ago

bloomdt-uw commented 3 years ago

Change includes validation, optional metadata and streamline files.

36000 commented 3 years ago

This looks really good! The only thing left on my end is how to handle bundles where no streamlines are found, because I am generating the streamlines.json from the first subject's tractogram. Also, I am not sure what numbering system is used in streamlines.json for the non-core streamlines (they seem to be all multiples of 5? Maybe something to ask Jason or Adam).

bloomdt-uw commented 3 years ago

Definitely something to ask @richford or @arokem, but I believe the numerical streamlines keys are likely the indicies from a proportional subsample of the streamlines from the subjects tractogram.

For example the "default" streamline file (afqbrowser/site/client/data/streamlines.json) tracts appear to be every fifth streamline.

arokem commented 3 years ago

LGTM! Thank you for the detailed implementation.