search

yegor256 / qulice

Quality Police for Java projects: aggregator of Checkstyle and PMD
https://www.qulice.com
Other
301 stars 112 forks source link

Remove stale 'todos' for PDD-related checks #1188

Closed k3p7i3 closed 12 months ago

k3p7i3 commented 1 year ago

Puzzles from Brackets.java were added as the test for PuzzleDuplicateCheck (#143), and puzzles from Pdd.java were added as the test for prohibited pdd format (#124). Both PDD checks were deleted at commit 8c29230, but related todos weren't removed, so it's time to do it now. Pdd.java file is removed because all checks there were connected for testing puzzle format, but after deleting pdd checks it doen't make sense.

Closes: #1119, #1120, #1121, #1122

k3p7i3 commented 12 months ago

@yegor256 review this pr, please

yegor256 commented 12 months ago

@rultor merge

rultor commented 12 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 12 months ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)