search

yeoman / generator-chrome-extension

Scaffold out a Chrome extension
http://yeoman.io
MIT License
2.62k stars 224 forks source link

Bump gulp-eslint to work with used babel-eslint #214

Closed irnc closed 4 years ago

irnc commented 5 years ago

gulp lint fails with Parsing error: Cannot find module 'eslint-scope' from '/usr/src/extension/node_modules/eslint/lib/api.js'

This is because babel-eslint@^10.0.1 (introduced at pull request #209) requires newer eslint than the one installed by gulp-eslint, which is clearly stated during npm install stage:

npm WARN babel-eslint@10.0.3 requires a peer of eslint@>= 4.12.1 but none is installed. You must install peer dependencies yourself.

This pull request updates gulp-eslint to the latest v6.0.0, which has eslint@^6.0.0 as dependency, thus satisfying babel-eslint peer dependency requirement.