search

yesodweb / yesodweb.com-content

Content for the www.yesodweb.com site
http://www.yesodweb.com/
Other
67 stars 112 forks source link

Add attributes to nested route #175

Closed maxigit closed 8 years ago

maxigit commented 8 years ago

I'm not sure if it's the right place to suggest this, so I apologize it is not. Having playing with route attributes and hierarchical route and I discover that you It works as excepted, ie , children inherists from parent attributes. However, the syntax is no that straight forward, as the colon needs to be after the attributes. e.g,

/admin AdminR !admin: /1 Admin1R !a /2 Admin2R !b

then routeAttrs (Admin1R) returns `fromList ("admin", "a").

It's a really cool feature which I think could be addd in the route attributes pages.

snoyberg commented 8 years ago

That sounds good, interested in sending a PR to add such content?

On Sun, Sep 4, 2016, 12:58 PM Max notifications@github.com wrote:

I'm not sure if it's the right place to suggest this, so I apologize it is not. Having playing with route attributes and hierarchical route and I discover that you It works as excepted, ie , children inherists from parent attributes. However, the syntax is no that straight forward, as the colon needs to be after the attributes. e.g,

/admin AdminR !admin: /1 Admin1R !a /2 Admin2R !b

then routeAttrs (Admin1R) returns `fromList ("admin", "a").

It's a really cool feature which I think could be addd in the route attributes pages.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yesodweb/yesodweb.com-content/issues/175, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB1rgqNzYlnGtJU4N3-FFjEC1aKyKks5qmpZRgaJpZM4J0f-w .

maxigit commented 8 years ago

I can try. Should I modify the route attributes page ?

snoyberg commented 8 years ago

Sure, sounds good. Just update the asciidoc

On Sun, Sep 4, 2016, 2:36 PM Max notifications@github.com wrote:

I can try. Should I modify the route attributes page ?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/yesodweb/yesodweb.com-content/issues/175#issuecomment-244598331, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBByHM1rhsoBPV46uGCMkgG6SrGq_Eks5qmq1FgaJpZM4J0f-w .

maxigit commented 8 years ago

Just checking if you've seen the update to the pull request.

snoyberg commented 8 years ago

No, I hadn't, thanks!