Should `console_error_panic_hook` be moved to `[dev-dependencies]`?

yewstack / yew-wasm-pack-template

A template for starting a Yew project to be used with wasm-pack

https://todomvc.yew.rs/

Apache License 2.0

118 stars 41 forks source link

Should `console_error_panic_hook` be moved to `[dev-dependencies]`? #3

Closed kellytk closed 4 years ago

kellytk commented 5 years ago

Considering the language and stated performance overhead beginning at https://github.com/yewstack/yew-wasm-pack-template/blob/master/Cargo.toml#L24 should console_error_panic_hook be moved to [dev-dependencies]?

hgzimmerman commented 4 years ago

I think its fine as a default-on feature-gated dependency. Something someone can turn off when they decide to build for deployment.

I think the general practice for yew ecosystem crates is to have everything within reason be enabled by default, but able to be turned off when people decide they need to start caring about wasm file size.