search

yi-editor / yi

The Haskell-Scriptable Editor
GNU General Public License v2.0
1.51k stars 200 forks source link

Multiple minibuffers can be opened; all but one treated as 'file' buffers #157

Open ethercrow opened 11 years ago

ethercrow commented 11 years ago

Original author: reiner.p...@gmail.com (May 11, 2011 00:36:09)

What steps will reproduce the problem?

  1. yi --as=emacs
  2. C-x C-f C-x Cf (i.e. open-file twice)

What happens? Two minibuffers open. After selecting a file (say, foo.txt) in the first, that file will open in the other minibuffer, rather than in the main buffer.

What should happen? I would not expect multiple minibuffers to open (is there a reason to want this behaviour?). The file should open in the main buffer.

Notes You can reproduce this behaviour with most commands which open the minibuffer, e.g. 'C-x b' instead of 'C-x C-f'.

Original issue: http://code.google.com/p/yi-editor/issues/detail?id=349

ethercrow commented 11 years ago

From JeanPhil...@gmail.com on May 11, 2011 07:18:36 Here's a sane way to look at it: there are no "minibuffers", only miniwindows. Yi does not prevent opening a file in a miniwindow.

ethercrow commented 9 years ago

I think it's best to restrict minibuffer's keymap to readline plus some command-specific additions instead of having full emacs keymap there.

Fuuzetsu commented 9 years ago

I definitely disagree. If we happen to be crafting some bigger command in there, we want to be able to use the stuff we normally do.

Same with recursive minibuffer, found this to be quite useful in the past.

EDIT: I think we should just stop or warn the user if they try to open a file in the minibuffer.