search

yibaini / thread-sanitizer

Automatically exported from code.google.com/p/thread-sanitizer
0 stars 0 forks source link

Allow inline comments in the suppressions file #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently the matched suppressions printed aren't attributed to their bug IDs, 
so it's hard to check whether a particular bug is fixed or not.
I suggest to allow free-form text annotations in the one-line suppressions that 
can be printed together with the matched suppressions.
We can either extend the semantics of the # symbol to allow inline comments in 
the suppressions:
  race:foobar  # bug 30

or can add some other form of annotations, e.g.:
  {bug 30}race:foobar

Original issue reported on code.google.com by gli...@google.com on 20 Sep 2013 at 8:39

GoogleCodeExporter commented 9 years ago 
Is it still relevant? Do you still want this?

I would prefer to not complicate suppressions format. Comments on separate 
lines seem to work fine:

# Comment
suppression

Original comment by dvyu...@google.com on 2 Sep 2014 at 2:24

GoogleCodeExporter commented 9 years ago 
Probably no. We didn't need this during deployment

Original comment by gli...@chromium.org on 10 Sep 2014 at 2:40

GoogleCodeExporter commented 9 years ago

Original comment by dvyu...@google.com on 10 Sep 2014 at 8:10

GoogleCodeExporter commented 9 years ago 
Adding Project:ThreadSanitizer as part of GitHub migration.

Original comment by gli...@google.com on 30 Jul 2015 at 9:21