search

yiisoft / yii2-elasticsearch

Yii 2 Elasticsearch extension
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
427 stars 253 forks source link

Fix master branch tests #255

Closed ArekX closed 4 years ago

ArekX commented 4 years ago
Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #232
ArekX commented 4 years ago

@samdark It looks like there is an issue with Travis CI, the build didn't even get to the part of running the tests.

samdark commented 4 years ago

@ArekX yes, setup is problematic as well.

xepozz commented 4 years ago

Thank you for fixing travis :)

ArekX commented 4 years ago

Thank you for fixing travis :)

You are welcome :)

@samdark I had to put everything on trusty. Elasticsearch 1.7 does not support newer version of OpenJDK VM so it doesn't want to run.

samdark commented 4 years ago

Wow! Love how fast you did it. I was trying to fix it for a few days and eventually gave up :)

samdark commented 4 years ago

@AlexGx do you have some extra time to fix 2.1 branch as well?

schmunk42 commented 4 years ago

What's with newer versions of ES?

ArekX commented 4 years ago

What's with newer versions of ES?

ES has changed too much between versions. Newest one (7.5 at this time) removed mapping types (aside from all other breaking changes) which IMO requires core of the functionality of this extension to be changed which will incur a lot of breaking changes so I don't think it's coming anytime soon.

schmunk42 commented 4 years ago

Might be good to ~add~ update supported versions to the README

samdark commented 4 years ago

Yes, supported versions is a must. We need to make it clear what version of extension is for what version of ElasticSearch. After merging this pull request I plan making last release from master and making 2.1 current branch. After tests there are passing, we can release from it.

samdark commented 4 years ago

Thank you very much.