yiisoft / yii2-elasticsearch

Yii 2 Elasticsearch extension
http://www.yiiframework.com
BSD 3-Clause "New" or "Revised" License
429 stars 252 forks source link

Fix yiisoft/yii2#20202 #350

Closed lav45 closed 1 month ago

lav45 commented 1 month ago
Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues yiisoft/yii2#20202
samdark commented 1 month ago

It will just install older version. It's better to fix the reason for such behavior.

lav45 commented 1 month ago

@samdark I fixed the error, but the build still doesn't work. Also, we need to somehow reconcile the versions of yii2-elasticsearch and yii2, but I don't yet understand how. yii2:2.0.50 works with php>=7.4, while yii2-elasticsearch requires php>=5.6.

terabytesoftw commented 1 month ago

@samdark I fixed the error, but the build still doesn't work. Also, we need to somehow reconcile the versions of yii2-elasticsearch and yii2, but I don't yet understand how. yii2:2.0.50 works with php>=7.4, while yii2-elasticsearch requires php>=5.6.

https://github.com/yiisoft/yii2-elasticsearch/pull/346 review this pr.

samdark commented 1 month ago

@terabytesoftw merged. @lav45 can you resolve conflicts please?

terabytesoftw commented 1 month ago

I can confirm that the latest ActiveDataProvider::class in Yii2 change resolves the segmentation issue in ElasticSearch.

https://github.com/terabytesoftw/yii2-elasticsearch/actions/runs/9546397753/job/26309179454

samdark commented 1 month ago

@terabytesoftw you mean this PR isn't needed?

terabytesoftw commented 1 month ago

@terabytesoftw you mean this PR isn't needed?

I'm saying that now the fix works with https://github.com/yiisoft/yii2/pull/20206

samdark commented 1 month ago

@terabytesoftw seems elastic search doesn't build anymore :(

samdark commented 1 month ago

@lav45 can you add a line for CHANGELOG? Thanks.

samdark commented 1 month ago

Thank you!