Gnome 46.rc1 Crashes when enabling the extension

p0ryae commented 3 months ago

Title says it. Had to disable validation by settings org.gnome.shell disable-extension-version-validation true to check, but as soon as the extension is enabled the whole desktop crashes, and any sort of login will lead to a crash.

I'm using Arch Linux (gnome-unstable mirror) with kernel version 6.8.1.

garaevdi commented 3 months ago

I guess this is because of this. In src/effect/rounded_corners_effect.ts in method vfunc_build_pipeline an extension tries to get uniforms' locations. Before mutter's patch this worked fine, since cogl_pipeline_get_unfiorm_location used default context for every cogl_pipeline. I'm not entirely sure, since I'm not that experienced with C and can't really read mutter's code, but now each pipeline uses it's own context. At this function's call effect's pipeline isn't built yet, so there is no context, which results in SEGFAULT.

I don't know how to properly fix this, but if someone really needs these rounded corners, you can move this._init_uniforms () into update_uniforms() method. This will decrease performance a bit and idk if this would work for you, but my rounded corners are back.

prastowoagungwidodo commented 3 months ago

I guess this is because of this. In src/effect/rounded_corners_effect.ts in method vfunc_build_pipeline an extension tries to get uniforms' locations. Before mutter's patch this worked fine, since cogl_pipeline_get_unfiorm_location used default context for every cogl_pipeline. I'm not entirely sure, since I'm not that experienced with C and can't really read mutter's code, but now each pipeline uses it's own context. At this function's call effect's pipeline isn't built yet, so there is no context, which results in SEGFAULT.

I don't know how to properly fix this, but if someone really needs these rounded corners, you can move this._init_uniforms () into update_uniforms() method. This will decrease performance a bit and idk if this would work for you, but my rounded corners are back.

Wow. thanks. it working on my desktop.

EisregenHaha commented 3 months ago

I guess this is because of this. In src/effect/rounded_corners_effect.ts in method vfunc_build_pipeline an extension tries to get uniforms' locations. Before mutter's patch this worked fine, since cogl_pipeline_get_unfiorm_location used default context for every cogl_pipeline. I'm not entirely sure, since I'm not that experienced with C and can't really read mutter's code, but now each pipeline uses it's own context. At this function's call effect's pipeline isn't built yet, so there is no context, which results in SEGFAULT.

I don't know how to properly fix this, but if someone really needs these rounded corners, you can move this._init_uniforms () into update_uniforms() method. This will decrease performance a bit and idk if this would work for you, but my rounded corners are back.

would you mind sharing your extensions, all your words that have been spoken say nothing to me but i need my crounded corners back badly

garaevdi commented 3 months ago

would you mind sharing your extensions, all your words that have been spoken say nothing to me but i need my crounded corners back badly

Sure, here is my fork. Though I want to say one more time, that this isn't proper fix, more like a bandage. I noticed some fuzzy behavior with chomium/electron based apps, and I can't tell if it's because of this patch.

EisregenHaha commented 3 months ago

would you mind sharing your extensions, all your words that have been spoken say nothing to me but i need my crounded corners back badly

Sure, here is my fork. Though I want to say one more time, that this isn't proper fix, more like a bandage. I noticed some fuzzy behavior with chomium/electron based apps, and I can't tell if it's because of this patch.

just saw the commit, didnt think its that easy. huge thanks though, idc if its a bandage as long as it works

spxak1 commented 2 months ago

would you mind sharing your extensions, all your words that have been spoken say nothing to me but i need my crounded corners back badly

Sure, here is my fork. Though I want to say one more time, that this isn't proper fix, more like a bandage. I noticed some fuzzy behavior with chomium/electron based apps, and I can't tell if it's because of this patch.

just saw the commit, didnt think its that easy. huge thanks though, idc if its a bandage as long as it works

Hi there, could you be more specific as to how to make this work? Following the link to @garaevdi 's fork, I can't compile it and I get errors (will update when on my F40 computer). Thank you.

l3ifk commented 2 months ago

After this patch the extension does not work and gives me this error:SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/shell/misc/extensionUtils.js:4:0

l3ifk commented 2 months ago

would you mind sharing your extensions, all your words that have been spoken say nothing to me but i need my crounded corners back badly

Sure, here is my fork. Though I want to say one more time, that this isn't proper fix, more like a bandage. I noticed some fuzzy behavior with chomium/electron based apps, and I can't tell if it's because of this patch.

just saw the commit, didnt think its that easy. huge thanks though, idc if its a bandage as long as it works

Hi there, could you be more specific as to how to make this work? Following the link to @garaevdi 's fork, I can't compile it and I get errors (will update when on my F40 computer). Thank you.

Did you manage to get it working?

spxak1 commented 2 months ago

https://github.com/ByloTonix/fedora-workstation-afterinstall-notes/blob/main/rounded-window-corners.zip

I just used this with F40. It works fine.

l3ifk commented 2 months ago

Yes thanks it works now. I really like the rounded corners, but the bug that after waking from suspend switching workspaces with the keyboard shortcut or the touchpad gestures is broken, is just too big of a deal for me :/ I hope there will be a new possibility to get rounded corners soon...

spxak1 commented 2 months ago

Yes thanks it works now. I really like the rounded corners, but the bug that after waking from suspend switching workspaces with the keyboard shortcut or the touchpad gestures is broken, is just too big of a deal for me :/ I hope there will be a new possibility to get rounded corners soon...

I have tested every single one of my (many) extensions to find what is causing this issue, and I have concluded it's blur-my-shell. I just tested it again. Has your testing pointed to the rounded windows corners?

Edit: More testing, it appears the it's the combination of rounded windows corners with blur-my-shell. If either is off, things work as they should.

l3ifk commented 2 months ago

Yes thanks it works now. I really like the rounded corners, but the bug that after waking from suspend switching workspaces with the keyboard shortcut or the touchpad gestures is broken, is just too big of a deal for me :/ I hope there will be a new possibility to get rounded corners soon...

I have tested every single one of my (many) extensions to find what is causing this issue, and I have concluded it's blur-my-shell. I just tested it again. Has your testing pointed to the rounded windows corners?

Edit: More testing, it appears the it's the combination of rounded windows corners with blur-my-shell. If either is off, things work as they should.

instresting that it is the combination of both. I love both of these extensions thats a bummer...