search

yireo / Yireo_GoogleTagManager2

Open Software License 3.0
148 stars 76 forks source link

Added telephone for enhanced ecommerce #220

Closed JuulGr closed 8 months ago

JuulGr commented 8 months ago

Added the sha256 telephone number to the datalayer for a question about extending enhanced e-commerce. Can we add all the other possible fields like this (city, region, zip, lastname ...) or should we bundle it for performance issues due to the call to getOrder.

jissereitsma commented 8 months ago

I think for the sake of performance, reusing the order repository is not too bad. But for cluttering the code, it makes far more sense to unduplicate code and make one major class for all properties. Let me work on this right away and get back to you here.

jissereitsma commented 8 months ago

I'm closing this PR after all, as I have added the fix I mentioned earlier: https://github.com/yireo/Yireo_GoogleTagManager2/commit/10629971913358e1401c0819c8ab8ccb1392de3a

Could you extend up that class to add the fields you wanted?