Open jmoudrik opened 10 months ago
Issue: Currently, y-prosemirror does not build against yjs newer (or equal) than v13.5.45, it npm run dist throws:
y-prosemirror
yjs
v13.5.45
npm run dist
src/plugins/sync-plugin.js:662:36 - error TS2554: Expected 0 arguments, but got 1. 662 const attrs = el.getAttributes(snapshot) ~~~~~~~~ Found 1 error in src/plugins/sync-plugin.js:662
Cause: In yjs, the el.getAttributes(snapshot) was changed to el.getAttributes(), (the implementation did not use the snapshot arg anyway) here - if I am git blaming correctly :-) https://github.com/yjs/yjs/compare/v13.5.44...v13.5.45#diff-c299d1b6aeba1b81704fa26fd317da05091111fc72ac264c0772d2563ed9f6f8L1237
el.getAttributes(snapshot)
el.getAttributes()
git blaming
Fix:
package.json
Issue: Currently,
y-prosemirror
does not build againstyjs
newer (or equal) thanv13.5.45
, itnpm run dist
throws:Cause: In
yjs
, theel.getAttributes(snapshot)
was changed toel.getAttributes()
, (the implementation did not use the snapshot arg anyway) here - if I amgit blaming
correctly :-) https://github.com/yjs/yjs/compare/v13.5.44...v13.5.45#diff-c299d1b6aeba1b81704fa26fd317da05091111fc72ac264c0772d2563ed9f6f8L1237Fix:
package.json
deps to the lowestyjs
version with the arg removed