ADD Feature does not account for proper validation checks on NRIC Number

[yleeyilin]

Steps to reproduce:

• As per the UG, I have inputted add ic/S0914567D n/John Doe g/M b/10-07-2003 p/98765432 e/johnd@example.com d/Penicillin|\nCephalosporins i/Infectious Diseases i/Genetic Disorders, which has the wrong match of NRIC and birthday.

Expected:

• I expected to get an error message telling me to check the birthday and ic number since people born after 2000 have NRIC that starts with T not S.

Actual:

• However, I got a success message instead instead.

Screenshots:

This is problematic as this could have been a typo from the users' part. You can consider supporting this for better convenience and usability for your users. One way you can do is by throw a warning message for such mismatch.

[nus-se-bot]

Team's Response

You are right regarding the NRIC digits not having appropriate validation. It has actually been taken note of during PE-D and has been added into the DG's Planned enhancements and thus considering this as NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---