yleeyilin / pe

0 stars 0 forks source link

Edit feature does not show an accurate success message #9

Open yleeyilin opened 5 months ago

yleeyilin commented 5 months ago

Steps to reproduce:

Expected:

Actual:

Screenshots: image.png

This is problematic as it does not include even the drug allergies field, which makes the output irrelevant to the command made. You can consider supporting this for better convenience and usability for your users. One way you can do is by identifying the exact fields edited, or changing the success message such that all the fields are shown always. This is the same problem for all other functions such as add.

nus-se-script commented 5 months ago

Team's Response

This is indeed an issue that was also found during PE-D. Our team has included it in the future-release pipeline and could also be found in DG Planned Enhancements.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: While I take responsibility for overlooking your group's planned enhancement, I believe that your planned enhancement is far too broad.

From the TP guidelines, planned enhancement should be separated if solving one does not fix the other.

image.png

In your case, I believe adding the error message to include the drug allergy attribute will not help solve the missing attribute for birthdate etc. Hence, each of these attributes should have been placed in separate planned enhancement.

After consulting with Prof Damith, since adherence to the guidelines is paramount for ensuring the integrity and effectiveness of enhancements, it is valid to reject your team's decision on the grounds that your planned enhancement do not comply with the given guidelines.