search

ynput / ayon-houdini

Houdini addon for AYON
Apache License 2.0
9 stars 6 forks source link

Houdini: Support for Redshift lightgroups #10

Open antirotor opened 4 months ago

antirotor commented 4 months ago

Is there an existing issue for this?

Please describe the feature you have in mind and explain what the current shortcomings are?

Publishing renders from Houdini Redshift doesn't support lightgroups. They are rendered, but not published because they are missing from expectedFiles.

How would you imagine the implementation of the feature?

Maybe we should implement something like RenderProducts from Maya to handle this. Currently every render collector is taking care of it's own stuff which might be fine. Nevertheless, support for Lightgroups should be added - adding lightgroup name to AOV in expected files.

Are there any labels you wish to add?

Describe alternatives you've considered:

No response

Additional context:

No response

[cuID:AY-5335]

BigRoy commented 4 months ago

Oh. The love of renderers, this really has been made so much easier in Solaris with USD becaue it's the RenderProducts and its RenderVar in the USD stage that define the render outputs - which makes the behavior unified across renderers requiring just a single logic for all the supported renderers.

Always disliked this per renderer customization needed.

Maybe we should implement something like RenderProducts from Maya to handle this.

Good question. I must admit I originally implemented that (I think?) but over time didn't necessarily feel it 'unified' things sufficiently to make it way easier to implement a new renderer for the maya system. So whether it was a good decision I think is heavily up for debate. Hard to say whether it solved enough or not.

If others like the code design/usage then I guess it did.

antirotor commented 4 months ago

Hard to say whether it solved enough or not.

If others like the code design/usage then I guess it did.

I think it solved it definitely in Maya. With Houdini, I am not sure because querying data there is imho more straightforward so maybe leaving it to the collectors as it is now is the way. Not having clear opinion on that either.

lucasbruchhage commented 4 months ago

adding it in the collectors is probably the easiest and fastest solution, but might be a bit fragile, sadly we do not have a predefined Variable like $AOV but most render engines seem to just throw the light group name straight behind the AOV name anyways so might be quite easy to extract that.

lucasbruchhage commented 4 months ago

If I understand it correctly, everthing that ends up in the expected files array, will be successfully published? @antirotor