search

yobix-ai / extractous

Fast and efficient unstructured data extraction. Written in Rust with bindings for many languages.
Apache License 2.0
448 stars 17 forks source link

Test Multiple Python Versions (+3.13 Support) #20

Open TheTechromancer opened 3 weeks ago

TheTechromancer commented 3 weeks ago

Hey, first off thanks for making this library! It works perfectly and is by far the best such library we've found for Python. Compiling Tika using GraalVM was an awesome idea.

We are working on adding Python 3.13 support to our project, which uses extractous. This PR updates the Python version and also the CI to test multiple python versions, including Python 3.13. PyO3 recently added support.

image

Downstream issue:

nmammeri commented 3 weeks ago

Thanks for the pull request. We are glad that you like extractous.

It seems that pyo3 have support for python 3.13. We should upgrade to ver 0.22.6.

TheTechromancer commented 3 weeks ago

We should upgrade to ver 0.22.6.

I updated PyO3 and separated out the python version tests into their own job. Tests should pass now 🤞

nmammeri commented 3 weeks ago

I think what you had before this latest commit is better. We need just to add the python-version when uploading the artifact.

TheTechromancer commented 3 weeks ago

Should we upload all the wheel versions? I think we should only need the lowest one, i.e. 3.8.

nmammeri commented 3 weeks ago

The Upload wheels step just uploads them to Github, then the Pytest step downloads them and run the tests.

Uploading to PyPi I'm not really sure what's the common practice for python. It might be as you said, we only need to upload the lowest possible one

TheTechromancer commented 2 weeks ago

This should be g2g

TheTechromancer commented 4 days ago

@nmammeri any news on when this might be merged?

Thanks