yokai-php / sonata-workflow

Integrate Symfony workflow component in Sonata Admin
MIT License
22 stars 11 forks source link

Compatibility with Sonata 4.x #30

Closed yann-eugone closed 2 years ago

yann-eugone commented 3 years ago

There is too much differences between Sonata 3.x & 4.x.

Decided to drop sonata 4.x support for the next version :

codecov[bot] commented 3 years ago

Codecov Report

Merging #30 (fd7fda3) into main (5f0f6bd) will increase coverage by 0.11%. The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #30      +/-   ##
============================================
+ Coverage     91.02%   91.13%   +0.11%     
  Complexity       44       44              
============================================
  Files             2        2              
  Lines           156      158       +2     
============================================
+ Hits            142      144       +2     
  Misses           14       14              
Impacted Files Coverage Δ
src/Controller/WorkflowControllerTrait.php 81.42% <80.00%> (ø)
src/Admin/Extension/WorkflowExtension.php 98.86% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f0f6bd...fd7fda3. Read the comment docs.

danaki commented 3 years ago

RouterCollection should be replaced by RouterCollectionInterface, but now I'm getting strange error like:

An exception has been thrown during the rendering of a template ("unable to find the route `admin_app_productfeedback.workflow_apply_transition`").

While I have this route configure except it has "_" instead of ".":

  admin_app_productfeedback_workflow_apply_transition         ANY      ANY      ANY    /admin/app/productfeedback/{id}/workflow/transition/{transition}/apply
yann-eugone commented 3 years ago

RouterCollection should be replaced by RouterCollectionInterface, but now I'm getting strange error like:

Yes, but I see no way to have single version of this library for the 2 versions of SonataAdmin. And as there is no date for the 4.x stable version, I'm not sure I want to create a new major for the moment.


The other error is very strange indeed, because the library never calls the router with entire route names. All routes are generated using AdminInterface::generateObjectUrl(), I'm really not sure why you are getting something like this.

danaki commented 3 years ago

After composer update problems with routes have gone away.