search

yokai-php / sonata-workflow

Integrate Symfony workflow component in Sonata Admin
MIT License
22 stars 11 forks source link

Changed return type of WorkflowControllerTrait::getWorkflow for WorkflowInterface #37

Closed KevinEcotree closed 8 months ago

KevinEcotree commented 8 months ago

With Symfony 6.4, I get this error: Yokai\SonataWorkflow\Controller\WorkflowController::getWorkflow(): Return value must be of type Symfony\Component\Workflow\Workflow, Symfony\Component\Workflow\Debug\TraceableWorkflow returned

Changing the return value to WorkflowInterface corrects the problem.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e6b9fb4) 89.55% compared to head (1135a49) 89.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================= Coverage 89.55% 89.55% Complexity 45 45 ========================================= Files 2 2 Lines 201 201 ========================================= Hits 180 180 Misses 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yann-eugone commented 8 months ago

Hi :slightly_smiling_face:

I thought it was a duplicate of #36, but it seems that we just forgot another place where return type should be changed. So, thanks for this PR