search

yokai-php / sonata-workflow

Integrate Symfony workflow component in Sonata Admin
MIT License
22 stars 11 forks source link

Transition item is translated with a "leading" underscore #8

Closed gremo closed 4 years ago

gremo commented 5 years ago

Maybe a minor issue, but the getLabel method is missing the $type argument:

$menu->addChild(
    $admin->getLabelTranslatorStrategy()->getLabel($transition->getName(), 'workflow'),
    $options
);

Which leads to something like:

workflow:
    _accept: Accetta
    _reject: Rifiuta
    _submit: Invia
    _suspend: Sospendi

What about using "label" or "transition" as $type argument?

yann-eugone commented 4 years ago

Fixed as of v0.2.0