yokoffing / Betterfox

Firefox user.js for speed, privacy, and security. Your favorite browser, but better.
MIT License
5.5k stars 140 forks source link

Firefox crashes when opening local HTML file (file size > 4MB) #279

Closed onmyouji closed 6 months ago

onmyouji commented 6 months ago

BEFORE YOU BEGIN

I have attempted the following troubleshooting suggestions:

REPORT

Describe the bug Using Betterfox user.js causes Firefox to crash when opening local HTML file. The crash happens if the HTML file is larger than 4MB, smaller file doesn't cause crash.

To Reproduce

  1. Create a fresh new profile.
  2. Open a local HTML file that is bigger than 4MB. You can download this HTML file to your computer or use your own HTML file (> 4MB).
  3. File will open normally.
  4. Close Firefox, then put the user.js file to your profile folder.
  5. Load Firefox, then open the local HTML file from your computer.
  6. Your tab will crash and you get message "Gah. Your tab just crashed."

Expected behavior Firefox should not crash when opening a local HTML file from your computer.

Screenshots 2024-03-12_184834

Desktop (please complete the following information):

yokoffing commented 6 months ago

I can reproduce. I will look into it.

Apparently this is happening in Waterfox as well:

Update: I have confirmed it's reproducible in Floorp w/ Betterfox user.js.

Update: Does not occur in Librewolf.

yokoffing commented 6 months ago

@onmyouji Please reset the pref network.buffer.cache.size. It is causing the issue.

If you're starting with a new profile, remove that pref under Fastfox before applying the user.js.

onmyouji commented 6 months ago

Thanks, the issue was fixed after resetting it.

Should I close this issue or do you want to leave it open?

yokoffing commented 6 months ago

It’ll close once I push a release tomorrow.