search

yolain / ComfyUI-Easy-Use

In order to make it easier to use the ComfyUI, I have made some optimizations and integrations to some commonly used nodes.
GNU General Public License v3.0
1.1k stars 78 forks source link

For Loop incompatible with accumulation #403

Open rjgoif opened 2 months ago

rjgoif commented 2 months ago

Multiple implementations of looping have appeared, but Easy Use has the only one I've seen with flexible input count.

However, it doesn't work with all inputs, notably with the Accumulate node from this loop tool which allows you to gather the results of each loop for output as a group:

Failed to validate prompt for output 1533:
* AccumulateNode 1549:
  - Custom validation failed for node: input_types - Invalid type of accumulation: FLOW_CONTROL (expected ACCUMULATION)

It looks like the loop is converting the type for some reason. The full loop suite of execution-inversion-demo-comfyui doesn't have this problem, so i know it's possible. I think the underlying problem is that the Easy Use loop is doing some sort of type conversion in general that it doesn't need to do.

Example of broken looping: looping broken

Successful alternative using execution-inversion-demo-comfyui: loop success

yolain commented 2 months ago

You can use batch any instead.

fAIseh00d commented 1 month ago

Here you go @rjgoif, workflow is embedded in the png.

workflow (25)