The mod attempts to load settings from a path with hardcoded backslash '\', breaking cross-platform compatibility

yoship1639 / ValheimVRM

Mod to replace Valheim player with VRM model.

MIT License

53 stars 19 forks source link

The mod attempts to load settings from a path with hardcoded backslash '\', breaking cross-platform compatibility #17

Closed BeryllArgent closed 2 years ago

BeryllArgent commented 2 years ago

Settings.cs Line 12 always inserts a backslash, regardless of what operating system the game is running on.

Since the game is cross-platform and also runs on Linux, this causes the problem that the settings file can not be found where it should be.

Replacing the backslash with just a slash '/', System.IO.Path.DirectorySeparatorChar, or using the Path.Combine function would easily fix this and still work on Windows just as well. I can create a pull request if desired.

Isaiahmag commented 2 years ago

I was wondering why it wouldn't work.

yoship1639 commented 2 years ago

Thanks for the report. I fixed it in ver 1.1.1.