search

yoshuawuyts / futures-concurrency

Structured concurrency operations for async Rust
https://docs.rs/futures-concurrency
Apache License 2.0
413 stars 33 forks source link

Implement no_std tests #159

Closed jmintb closed 1 year ago

jmintb commented 1 year ago

Hi, this is a draft PR for #68 to see if I am going in the right direction.

I have taken a test for the Join implementation on array and copied it into a no_std environment. I believe this should validate that Join works in a no_std environment.

Am I correct in assuming that a single test for Join is sufficient? as we are validating that traits work in no_std not specific implementations.

Let me know if this is the sort of thing you had in mind :)

yoshuawuyts commented 1 year ago

This seems great; yes please keep going in this direction!

jmintb commented 1 year ago

Alright, there is now one test for each trait. I again just reused existing tests so I could easily have missed something. let me know what you think :)