by-AttributeError/KeyError-catchable ObjectMapper attribute misses

youknowone / itunes-iap

Apple iTunes In-app purchase verification tool

http://itunes-iap.readthedocs.io

Other

136 stars 50 forks source link

by-AttributeError/KeyError-catchable ObjectMapper attribute misses #27

Closed yoloseem closed 8 years ago

yoloseem commented 8 years ago

Motivation:

KeyError from attribute access is unexpectable.

Changes:

Raise other exception could be caught by AttributeError, rather than KeyError.
To prevent unintended breaking on codes may be using KeyError to catch that cases, created MissingFieldError inherited both AttributeError and KeyError.

coveralls commented 8 years ago

Coverage increased (+0.5%) to 89.602% when pulling feb9a90095b2044fdddcfa0b0527b088ba3fa792 on yoloseem:attrmiss into 45a9cae4e80111b06fdb61bf87399d3ae81fa65e on youknowone:master.

codecov-io commented 8 years ago

Current coverage is 89.60%

Merging #27 into master will increase coverage by 0.51%

@@             master        #27   diff @@
==========================================
  Files             8          8          
  Lines           321        327     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            286        293     +7   
+ Misses           35         34     -1   
  Partials          0          0

Powered by Codecov. Last updated by 45a9cae...feb9a90

coveralls commented 8 years ago

Coverage increased (+0.2%) to 89.297% when pulling f6a39086f705925af051209d59ec288d2dbd79d7 on yoloseem:attrmiss into 45a9cae4e80111b06fdb61bf87399d3ae81fa65e on youknowone:master.