youmustfight / aframe-asset-lazy-load

An a-entity component to assign asset loading order and delays
https://youmustfight.github.io/aframe-asset-lazy-load/
MIT License
12 stars 6 forks source link

Consider removing jQuery dependency #1

Closed cvan closed 8 years ago

cvan commented 8 years ago

First off, really great work here! I especially like the chunking. So glad you wrote this. :+1:

I checked the source, and I didn't see any specific reason why jQuery would be needed. The $ calls could be replaced with document.querySelector (and document.querySelectorAll where appropriate) and $(el).attr(…) calls would just become el.getAttribute(…) calls.

FWIW, we have some utils for querying elements à la jQuery's $:

In 0.1.0/master of aframe/aframe-core, we aren't exposing these utils. But when we release 0.2.0, you'll be able to do require('aframe').utils.$ (or window.AFRAME.utils.$).

youmustfight commented 8 years ago

Totally agree, next thing I'm going to do. I was stuck on the load event for the asset.

youmustfight commented 8 years ago

jQuery annihilated!