younginnovations / iatipublisher

IATI Publishing Tool
GNU Affero General Public License v3.0
7 stars 0 forks source link

Make error message to user clearer when updating an organisation identifier in Publisher #1352

Open siwhitehouse opened 8 months ago

siwhitehouse commented 8 months ago

I have set up an account in Staging to troubleshoot and replicate issues. The organisation name is 'simon-troubleshooting'. For the issue I am trying to troubleshoot I need to update the organisation reference.

I go to https://iatipublisher-staging.yipl.com.np/organisation/organisation_identifier and I change the country, the Organisation Registration Agency and the Registration Number. I see that the organisation-identifier field is updated to the correct identifier and I have checked that this identifier also appears in the IATI Registry Staging site,

When I click on "Save and Exit" I am presented with the error message "Please enter correct identifier as present in IATI Registry." and the organisation-identifier field changes to the previous/existing identifier. I am unable to update the organisation-identifier.

I have been able to replicate this with two other publishers, chosen at random, from the publishes listed at https://staging.iatiregistry.org/publisher/

praweshsth commented 8 months ago

@siwhitehouse Please send us the whole process and data and if possible a screen record of it so that we can understand the issue.

siwhitehouse commented 8 months ago

Logged in as user 'simon-troubleshooting I go to https://iatipublisher-staging.yipl.com.np/organisation/organisation_identifier

image

I update the organisation identifier to the one whose error I want to replicate

image

That publisher exists in the staging site of the Registry, with the same identifier I have constructed in Publisher.

image

When I click on "Save and Exit".

image

I am presented with the error message "Please enter correct identifier as present in IATI Registry." and the organisation-identifier field changes to the previous/existing identifier. I am unable to update the organisation-identifier.

Please let me know when you have replicated this and I will obscure the organisation name from the images posted.

praweshsth commented 8 months ago

@siwhitehouse thank you for sharing the process. To change the organisation-identifier:

In your case the publisher id is not same as in IATI Registry staging. Hence it is not allowed to change.

siwhitehouse commented 8 months ago

@praweshsth They look exactly the same to me. What differences do you see, please?

praweshsth commented 8 months ago

@siwhitehouse the publisher ID of 'Simon-troubleshooting' is trouble and when you created the organisation in IATI Publisher, same ID was also created in IATI Registry. Both in publisher and registry, the publisher ID and organisation identifier are associated.

You tried to change the organisation identifier of 'Simon-troubleshooting' but in IATI registry the organisation identifier is not changed. And when you tried to change, it is showing the error.

praweshsth commented 7 months ago

@siwhitehouse @dan-odsc

Should we close this issue, because we have added JICA in staging which is mentioned in another issue #1340 ?

dan-odsc commented 7 months ago

Moving to proposed as there is further scoping/defining to do based on our call yesterday.

emmajclegg commented 7 months ago

We will likely de-prioritise this issue, but will suggest some improvements to the user feedback received when a user enters an organisation identifier that does not match their Registry account (for future UI enhancements).

e.g. an error message along the lines of "Your organisation identifier must match the identifier linked to your IATI Registry publisher ID"