search

yourduskquibbles / webannoyances

Fix and remove annoying web elements such as sticky headers, floating boxes, floating videos, dickbars, social share bars and other distracting elements.
Creative Commons Attribution Share Alike 4.0 International
1.31k stars 48 forks source link

youtube.com - "login" walls #245

Open krystian3w opened 4 years ago

krystian3w commented 4 years ago

URL(s) where the issue occurs

youtube.com

Describe the issue

Pop-up with new (?) string "Sign in to YouTube". It may appear at the first visit or after some time.

No have match into your regex: https://github.com/yourduskquibbles/webannoyances/blob/024c8dca77994fb6dad1d9576efac283ef40379c/filters/modal_filters.txt#L996-L998

Screenshot(s)

Versions

Settings

Notes

Maybe more globe range is use: :has(a[href^="https://support.google.com/youtube/?p=sign_in"])

youtube.com##ytd-popup-container > paper-dialog.ytd-popup-container[role="dialog"]:has(a[href^="https://support.google.com/youtube/?p=sign_in"])

Pop-up may use same background as cookie/rules policy:

www.youtube.com##body > .opened[opened][style^="z-index"]

Yaron10 commented 4 years ago

OK. Thanks again.

randomcookiemonster commented 4 years ago

I am now getting both login walls. 😞

I'll try adding: youtube.com###consent-bump:remove() youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer:remove() youtube.com##.opened:remove() to my filters (uBlock Origin) to if that at least removes the popup.

Thanks for the work you've done on this so far. 👍

krystian3w commented 4 years ago

Germany 🇩🇪 also should have pop-up (A/B test on more people...).

krystian3w commented 4 years ago

@randomcookiemonster try this: https://github.com/uBlockOrigin/uAssets/issues/7636#issuecomment-687200509

youtube.com##+js(set, yt_logging_screen, undefined)
Termuellinator commented 4 years ago

Just found out about this list, thank you, nice thing :+1:

Regarding Youtube, it has some issues though - it gets rid of the new annoying login-prompt, but the video is then stopped again for me and doesn't autoplay anymore. The other thing (probably the bigger issue tbh) is that on the YT-Homepage, the sidebar doesn't stay anymore, but scrolls up. And after some scrolling, the video-thumbnails don't show the video-duration anymore. When disabling the list and reloading, all is back to normal there.

krystian3w commented 4 years ago

the video is then stopped again for me and doesn't autoplay anymore.

Race contidion with :remove() - that can still stop video if you regularly clear cookies/localStorage. Login wall pop-up show rarer than Google GDPR.

The other thing (probably the bigger issue tbh) is that on the YT-Homepage, the sidebar doesn't stay anymore, but scrolls up. And after some scrolling, the video-thumbnails don't show the video-duration anymore. When disabling the list and reloading, all is back to normal there.

May need new topic "youtube - broken menu and miniatures at homepage" if not guilty is new :remove() filter.

randomcookiemonster commented 4 years ago

I'll try adding: youtube.com###consent-bump:remove() youtube.com##ytd-popup-container > paper-dialog > yt-upsell-dialog-renderer:remove() youtube.com##.opened:remove() to my filters (uBlock Origin) to if that at least removes the popup.

This has the side-effect of returnng the issue I described in an earlier my comment of mine, but I'll sum it up again. The video starts playing, after maybe 1 second the page reloads, and the video is paused at the beginning. I stopped uBlock Origin when this happened, and the popup login wall immediatelly showed up. Ater clicking "No thanks", restarting uBlock Origin and reloading the page the issue that's the topic of this comment was gone. But it will probably return next time the popup login wall is triggered.

randomcookiemonster commented 4 years ago

@randomcookiemonster try this: uBlockOrigin/uAssets#7636 (comment)

youtube.com##+js(set, yt_logging_screen, undefined)

Thanks I will.

krystian3w commented 4 years ago

Other user said "scriptlet no block pop-up / black rectangle above video".

randomcookiemonster commented 4 years ago

@randomcookiemonster try this: uBlockOrigin/uAssets#7636 (comment)

youtube.com##+js(set, yt_logging_screen, undefined)

This does not work.

Termuellinator commented 4 years ago

I only did some tests, but for me it seems that adding 

www.youtube.com###consent-bump
www.youtube.com##.opened
www.youtube.com##ytd-popup-container.ytd-app.style-scope

to my uBlock filters gets rid of the login nagscreen and prevents the video from pausing without impacting the yt main page. (taken from here )

krystian3w commented 4 years ago

##ytd-popup-container.ytd-app.style-scope break notfiy from bell "🔔" / subscribe / share as: https://github.com/yourduskquibbles/webannoyances/issues/245#issuecomment-686565977 / https://github.com/yourduskquibbles/webannoyances/issues/245#issuecomment-680988108

Also pop-up is visible once as per time (how long cookies expire) so simple CSS filter may generate FP with fix stop played video.

So far, this project has added 3 elements deletion on the page as fast as uBO/AdGuard can - similar to idea by Illusi (https://www.reddit.com/r/youtube/comments/im18pu/sign_in_spam_suddenly/g3whvel/)

c33s commented 4 years ago

now this also hit austria. can block it with the filters i found on reddit but it stops playing the video :(

because of cookie blocking i would get the login wall on each video

krystian3w commented 4 years ago

@c33s try:

https://github.com/uBlockOrigin/uAssets/issues/7842#issuecomment-694397422

youtube.com##+js(set-constant.js, ytInitialPlayerResponse.auxiliaryUi.messageRenderers.upsellDialogRenderer.isVisible, false)
youtube.com##+js(set-constant.js, ytInitialData.topbar.desktopTopbarRenderer.interstitial.consentBumpRenderer.forceConsent, false)

or Enable AdGuard Annoaynce, have same filters added as feedback test.

⚠️ No longer safe ⚠️

PS. we still no have solution for black "get the more YouTube experience" overlay.

Takuyax commented 4 years ago 
www.youtube.com###consent-bump
www.youtube.com##.opened
www.youtube.com##ytd-popup-container.ytd-app.style-scope

This worked great for me for a few days, but youtube now interrupts video playback immediately at startup with the attached error message. Reloading removed the error, but it immediately did the previously described auto-reload without autoplay. No idea if this can even be blocked, since it looks as if they're running some check to see if the nag-screen was displayed. Screenshot_20201002_162858

krystian3w commented 4 years ago

New without close button or hidden by non good filter.

krystian3w commented 3 years ago

For some people these may can break search bar: https://github.com/yourduskquibbles/webannoyances/blob/3cd5bf28282cc6724d63c4df23551d4caf361bce/filters/modal_filters.txt#L1012

Maybe better use:

youtube.com###upsell-dialog-text > a[href*="sign"]:upward(body > * > *)

yourduskquibbles commented 3 years ago

For some people these may can break search bar:

https://github.com/yourduskquibbles/webannoyances/blob/3cd5bf28282cc6724d63c4df23551d4caf361bce/filters/modal_filters.txt#L1012

Maybe better use:

youtube.com###upsell-dialog-text > a[href*="sign"]:upward(body > * > *)

@krystian3w I've updated to your suggestion in https://github.com/yourduskquibbles/webannoyances/commit/80188caad9a20253de997e464362c0e4ea9e2c90