search

yourkarma / JWT

A JSON Web Token implementation in Objective-C.
MIT License
351 stars 107 forks source link

Missing umbrella header #161

Open icedice opened 6 years ago

icedice commented 6 years ago

New Issue Checklist

Issue Info

Info Value
Platform Name ios
Integration Method carthage

Issue Description and Steps

I'm trying to build the framework with carthage, mit cartfile looks like this:

github "yourkarma/JWT" "master"

the framework builds without any issues but when I try to use it in my project (also a framework) i see the two following errors:

  1. /Carthage/Build/iOS/JWT.framework/Modules/module.modulemap:2:18: Umbrella header 'JWT.h' not found
  2. /Users/toke.refstrup/git/ios.auth/ios.auth/AuthManager.swift:3:8: Could not build Objective-C module 'JWT'

What am I doing wrong here?

Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

icedice commented 6 years ago

Ok I see now that there is no header files in the framework. Maybe it did not build correct anyway. Is it possible to build it with carthage?

lolgear commented 6 years ago

@icedice Hi! Could you try to specify latest commit instead of master branch?

icedice commented 6 years ago

Oh yes. Seems to work. Thanks. Will there be a new release soon so we don't need to target specific commit?

Also in podspec files you can only ask for version not specific commit....

You could just call it beta-7 that would be very helpfull

lolgear commented 6 years ago

@icedice Could you compare and post Carthage.resolved file content in both situations ( branch-oriented approach vs commit-oriented approach )?

Wow, do you use this library as a dependency for your sdk?

icedice commented 6 years ago

Well I use it as a helper in a login module for a app, its not really a SDK. Why wow? Would that be bad?

lolgear commented 6 years ago

@icedice no, wow as amusement :)

If you develop an application with modules, which are injected into an app via Cocoapods, you will faced with problems that you specify above. ( Podspec can't point to dependency via commit )

However, I released new version which solved CocoaPods dependencies, not Carthage dependencies.

Could you compare content of Cartfile.resolved in both situations with a commit and with a branch? I suppose that Carthage somehow point to different commits in these cases.

S2V commented 5 years ago

@lolgear I have a similar warning by using CocoaPod (JWT 3.0.0-beta.11) - Umbrella header for module 'JWT' does not include header 'JWTAlgorithmErrorDescription+Subclass.h'. Please update JWT.h in next release.