search

yoyostile / moneymoney-binance

Inofficial Binance Extension (www.binance.com) for MoneyMoney
7 stars 0 forks source link

Conflict with $BCC #3

Closed rbrtvnnmnn closed 6 years ago

rbrtvnnmnn commented 6 years ago

In Binance, $BCC is used for Bitcoin Cash, not BitConnect. However, using CryptoCompare API you get the price for BitConnect. Correct price can be queried using https://min-api.cryptocompare.com/data/price?fsym=BCH&tsyms=EUR

yoyostile commented 6 years ago

Nice find! Will have a look at this issue as soon as I got some spare time.

yoyostile commented 6 years ago

Okay, I pushed a new version of binance.lua. Please give it a try and let me know, if everything works correctly now. If you find even more currencies which are mapped incorrectly, please let me know.

rbrtvnnmnn commented 6 years ago

After updating to the latest version I get the error message Für diese Bank ist keine Web-Banking-Unterstützung vorhanden.

yoyostile commented 6 years ago

@rbrtvnnmnn are you still using the current beta? Is signature checking for extensions still disabled? In #4 everything seems to work just fine.

rbrtvnnmnn commented 6 years ago

I had signature checking for extensions enabled. Works now. Thanks! 👍