yshui / picom

A lightweight compositor for X11 with animation support
https://picom.app/
Other
4.09k stars 586 forks source link

Floating windows in Qtile are entirely black #647

Closed anriha closed 3 years ago

anriha commented 3 years ago

Platform

Gentoo amd64 5.12.12-zen1

GPU, drivers, and screen setup

nvidia-drivers-470.42.01 name of display: :0 display: :0 screen: 0 direct rendering: Yes Memory info (GL_NVX_gpu_memory_info): Dedicated video memory: 11264 MB Total available memory: 11264 MB Currently available dedicated video memory: 8303 MB OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: NVIDIA GeForce GTX 1080 Ti/PCIe/SSE2 OpenGL core profile version string: 4.6.0 NVIDIA 470.42.01 OpenGL core profile shading language version string: 4.60 NVIDIA OpenGL core profile context flags: (none) OpenGL core profile profile mask: core profile

OpenGL version string: 4.6.0 NVIDIA 470.42.01 OpenGL shading language version string: 4.60 NVIDIA OpenGL context flags: (none) OpenGL profile mask: (none)

OpenGL ES profile version string: OpenGL ES 3.2 NVIDIA 470.42.01 OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

Environment

qtile

picom version

vgit-e0967

Diagnostics [ 06/23/2021 21:02:19.062 init_render WARN ] Old backends only support blur method "kernel". Your blur setting will not be applied **Version:** vgit-e0967 ### Extensions: * Shape: Yes * XRandR: Yes * Present: Present ### Misc: * Use Overlay: Yes * Config file used: /home/anriha/.config/picom/picom.conf ### Drivers (inaccurate): NVIDIA ### Backend: glx * Driver vendors: * GLX: NVIDIA Corporation * GL: NVIDIA Corporation * GL renderer: NVIDIA GeForce GTX 1080 Ti/PCIe/SSE2

Configuration:

Configuration file ``` // Paste your configuration here ################################# # Shadows # ################################# # Enabled client-side shadows on windows. Note desktop windows # (windows with '_NET_WM_WINDOW_TYPE_DESKTOP') never get shadow, # unless explicitly requested using the wintypes option. # # shadow = false shadow = true; # The blur radius for shadows, in pixels. (defaults to 12) # shadow-radius = 12 shadow-radius = 7; # The opacity of shadows. (0.0 - 1.0, defaults to 0.75) # shadow-opacity = .75 # The left offset for shadows, in pixels. (defaults to -15) # shadow-offset-x = -15 shadow-offset-x = -7; # The top offset for shadows, in pixels. (defaults to -15) # shadow-offset-y = -15 shadow-offset-y = -7; # Red color value of shadow (0.0 - 1.0, defaults to 0). # shadow-red = 0 # Green color value of shadow (0.0 - 1.0, defaults to 0). # shadow-green = 0 # Blue color value of shadow (0.0 - 1.0, defaults to 0). # shadow-blue = 0 # Hex string color value of shadow (#000000 - #FFFFFF, defaults to #000000). This option will override options set shadow-(red/green/blue) # shadow-color = "#000000" # Specify a list of conditions of windows that should have no shadow. # # examples: # shadow-exclude = "n:e:Notification"; # # shadow-exclude = [] shadow-exclude = [ "name = 'Notification'", "class_g = 'Conky'", "class_g ?= 'Notify-osd'", "class_g = 'Cairo-clock'", "_GTK_FRAME_EXTENTS@:c" ]; # Specify a X geometry that describes the region in which shadow should not # be painted in, such as a dock window region. Use # shadow-exclude-reg = "x10+0+0" # for example, if the 10 pixels on the bottom of the screen should not have shadows painted on. # # shadow-exclude-reg = "" # Crop shadow of a window fully on a particular Xinerama screen to the screen. # xinerama-shadow-crop = false ################################# # Fading # ################################# # Fade windows in/out when opening/closing and when opacity changes, # unless no-fading-openclose is used. # fading = false fading = true; # Opacity change between steps while fading in. (0.01 - 1.0, defaults to 0.028) # fade-in-step = 0.028 fade-in-step = 0.06; # Opacity change between steps while fading out. (0.01 - 1.0, defaults to 0.03) # fade-out-step = 0.03 fade-out-step = 0.06; # The time between steps in fade step, in milliseconds. (> 0, defaults to 10) # fade-delta = 10 # Specify a list of conditions of windows that should not be faded. # fade-exclude = [] # Do not fade on window open/close. # no-fading-openclose = false # Do not fade destroyed ARGB windows with WM frame. Workaround of bugs in Openbox, Fluxbox, etc. # no-fading-destroyed-argb = false ################################# # Transparency / Opacity # ################################# # Opacity of inactive windows. (0.1 - 1.0, defaults to 1.0) # inactive-opacity = 1 inactive-opacity = 0.8; # Opacity of window titlebars and borders. (0.1 - 1.0, disabled by default) # frame-opacity = 1.0 frame-opacity = 0.7; # Let inactive opacity set by -i override the '_NET_WM_OPACITY' values of windows. # inactive-opacity-override = true inactive-opacity-override = false; # Default opacity for active windows. (0.0 - 1.0, defaults to 1.0) # active-opacity = 1.0 # Dim inactive windows. (0.0 - 1.0, defaults to 0.0) # inactive-dim = 0.0 # Specify a list of conditions of windows that should always be considered focused. # focus-exclude = [] focus-exclude = [ "class_g = 'Cairo-clock'" ]; # Use fixed inactive dim value, instead of adjusting according to window opacity. # inactive-dim-fixed = 1.0 # Specify a list of opacity rules, in the format `PERCENT:PATTERN`, # like `50:name *= "Firefox"`. picom-trans is recommended over this. # Note we don't make any guarantee about possible conflicts with other # programs that set '_NET_WM_WINDOW_OPACITY' on frame or client windows. # example: # opacity-rule = [ "80:class_g = 'URxvt'" ]; # # opacity-rule = [] ################################# # Background-Blurring # ################################# # blur: # { # method = "dual_kawase"; # strength = 2; # } # Parameters for background blurring, see the *BLUR* section for more information. blur-method = "dual_kawase"; # blur-size = 12 # # blur-deviation = false # blur-strength = 3 # Blur background of semi-transparent / ARGB windows. # Bad in performance, with driver-dependent behavior. # The name of the switch may change without prior notifications. # blur-background = true; # Blur background of windows when the window frame is not opaque. # Implies: # blur-background # Bad in performance, with driver-dependent behavior. The name may change. # # blur-background-frame = false # Use fixed blur strength rather than adjusting according to window opacity. # blur-background-fixed = false # Specify the blur convolution kernel, with the following format: # example: # blur-kern = "5,5,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1"; # # blur-kern = "" blur-kern = "3x3box"; # Exclude conditions for background blur. # blur-background-exclude = [] blur-background-exclude = [ "window_type = 'dock'", "class_g = 'slop'", "window_type = 'desktop'", "_GTK_FRAME_EXTENTS@:c" ]; ################################# # General Settings # ################################# # Daemonize process. Fork to background after initialization. Causes issues with certain (badly-written) drivers. # daemon = false # Specify the backend to use: `xrender`, `glx`, or `xr_glx_hybrid`. # `xrender` is the default one. # # backend = "glx" backend = "glx"; # Enable/disable VSync. # vsync = false vsync = true; # Enable remote control via D-Bus. See the *D-BUS API* section below for more details. # dbus = false # Try to detect WM windows (a non-override-redirect window with no # child that has 'WM_STATE') and mark them as active. # # mark-wmwin-focused = false mark-wmwin-focused = true; # Mark override-redirect windows that doesn't have a child window with 'WM_STATE' focused. # mark-ovredir-focused = false mark-ovredir-focused = true; # Try to detect windows with rounded corners and don't consider them # shaped windows. The accuracy is not very high, unfortunately. # # detect-rounded-corners = false detect-rounded-corners = true; # Detect '_NET_WM_OPACITY' on client windows, useful for window managers # not passing '_NET_WM_OPACITY' of client windows to frame windows. # # detect-client-opacity = false detect-client-opacity = true; # Specify refresh rate of the screen. If not specified or 0, picom will # try detecting this with X RandR extension. # # refresh-rate = 60 refresh-rate = 0; # Use EWMH '_NET_ACTIVE_WINDOW' to determine currently focused window, # rather than listening to 'FocusIn'/'FocusOut' event. Might have more accuracy, # provided that the WM supports it. # # use-ewmh-active-win = false # Unredirect all windows if a full-screen opaque window is detected, # to maximize performance for full-screen windows. Known to cause flickering # when redirecting/unredirecting windows. # # unredir-if-possible = false # Delay before unredirecting the window, in milliseconds. Defaults to 0. # unredir-if-possible-delay = 0 # Conditions of windows that shouldn't be considered full-screen for unredirecting screen. # unredir-if-possible-exclude = [] # Use 'WM_TRANSIENT_FOR' to group windows, and consider windows # in the same group focused at the same time. # # detect-transient = false detect-transient = true; # Use 'WM_CLIENT_LEADER' to group windows, and consider windows in the same # group focused at the same time. 'WM_TRANSIENT_FOR' has higher priority if # detect-transient is enabled, too. # # detect-client-leader = false detect-client-leader = true; # Resize damaged region by a specific number of pixels. # A positive value enlarges it while a negative one shrinks it. # If the value is positive, those additional pixels will not be actually painted # to screen, only used in blur calculation, and such. (Due to technical limitations, # with use-damage, those pixels will still be incorrectly painted to screen.) # Primarily used to fix the line corruption issues of blur, # in which case you should use the blur radius value here # (e.g. with a 3x3 kernel, you should use `--resize-damage 1`, # with a 5x5 one you use `--resize-damage 2`, and so on). # May or may not work with *--glx-no-stencil*. Shrinking doesn't function correctly. # # resize-damage = 1 # Specify a list of conditions of windows that should be painted with inverted color. # Resource-hogging, and is not well tested. # # invert-color-include = [] # GLX backend: Avoid using stencil buffer, useful if you don't have a stencil buffer. # Might cause incorrect opacity when rendering transparent content (but never # practically happened) and may not work with blur-background. # My tests show a 15% performance boost. Recommended. # # glx-no-stencil = false # GLX backend: Avoid rebinding pixmap on window damage. # Probably could improve performance on rapid window content changes, # but is known to break things on some drivers (LLVMpipe, xf86-video-intel, etc.). # Recommended if it works. # # glx-no-rebind-pixmap = false # Disable the use of damage information. # This cause the whole screen to be redrawn everytime, instead of the part of the screen # has actually changed. Potentially degrades the performance, but might fix some artifacts. # The opposing option is use-damage # # no-use-damage = false use-damage = true; # Use X Sync fence to sync clients' draw calls, to make sure all draw # calls are finished before picom starts drawing. Needed on nvidia-drivers # with GLX backend for some users. # # xrender-sync-fence = false # GLX backend: Use specified GLSL fragment shader for rendering window contents. # See `compton-default-fshader-win.glsl` and `compton-fake-transparency-fshader-win.glsl` # in the source tree for examples. # # glx-fshader-win = "" # Force all windows to be painted with blending. Useful if you # have a glx-fshader-win that could turn opaque pixels transparent. # # force-win-blend = false # Do not use EWMH to detect fullscreen windows. # Reverts to checking if a window is fullscreen based only on its size and coordinates. # # no-ewmh-fullscreen = false # Dimming bright windows so their brightness doesn't exceed this set value. # Brightness of a window is estimated by averaging all pixels in the window, # so this could comes with a performance hit. # Setting this to 1.0 disables this behaviour. Requires --use-damage to be disabled. (default: 1.0) # # max-brightness = 1.0 # Make transparent windows clip other windows like non-transparent windows do, # instead of blending on top of them. # # transparent-clipping = false # Set the log level. Possible values are: # "trace", "debug", "info", "warn", "error" # in increasing level of importance. Case doesn't matter. # If using the "TRACE" log level, it's better to log into a file # using *--log-file*, since it can generate a huge stream of logs. # # log-level = "debug" log-level = "warn"; # Set the log file. # If *--log-file* is never specified, logs will be written to stderr. # Otherwise, logs will to written to the given file, though some of the early # logs might still be written to the stderr. # When setting this option from the config file, it is recommended to use an absolute path. # # log-file = "/path/to/your/log/file" # Show all X errors (for debugging) # show-all-xerrors = false # Write process ID to a file. # write-pid-path = "/path/to/your/log/file" # Window type settings # # 'WINDOW_TYPE' is one of the 15 window types defined in EWMH standard: # "unknown", "desktop", "dock", "toolbar", "menu", "utility", # "splash", "dialog", "normal", "dropdown_menu", "popup_menu", # "tooltip", "notification", "combo", and "dnd". # # Following per window-type options are available: :: # # fade, shadow::: # Controls window-type-specific shadow and fade settings. # # opacity::: # Controls default opacity of the window type. # # focus::: # Controls whether the window of this type is to be always considered focused. # (By default, all window types except "normal" and "dialog" has this on.) # # full-shadow::: # Controls whether shadow is drawn under the parts of the window that you # normally won't be able to see. Useful when the window has parts of it # transparent, and you want shadows in those areas. # # redir-ignore::: # Controls whether this type of windows should cause screen to become # redirected again after been unredirected. If you have unredir-if-possible # set, and doesn't want certain window to cause unnecessary screen redirection, # you can set this to `true`. # wintypes: { tooltip = { fade = true; shadow = true; opacity = 0.75; focus = true; full-shadow = false; }; dock = { shadow = false; } dnd = { shadow = false; } popup_menu = { opacity = 0.8; } dropdown_menu = { opacity = 0.8; } }; ```

Steps of reproduction

  1. Use picom version after commit 2a60836a9bc30d92b4adb46d5f48684a5d2f1ecb
  2. Make window float in Qtile

Expected behavior

You can see content of the window.

Current Behavior

The window is entirely black.

Stack trace

Once the window is floating I get this output: [ 06/23/2021 20:46:18.806 _gl_compose ERROR ] GLX error at line 449: GL_INVALID_FRAMEBUFFER_OPERATION

Other details

Hopefully this is the right place to create an issue, it seems to me like picom problem because before the commit 2a60836a9bc30d92b4adb46d5f48684a5d2f1ecb everything worked as it should.

tryone144 commented 3 years ago

Probably a duplicate of #645. You haven't explicitly stated it, but I suspect you are using --experimental-backends?

Similarities are the nvidia driver and "zen1"-kernel at version 5.12.12.

anriha commented 3 years ago

Yes I forgot to state it I am using --experimental-backends. The difference is that in my case the window is entirely black. If you are suspecting that the kernel version or zen kernel is the problem I can test with older versions/different kernels. If I don't use experimental backends everything works fine.

tryone144 commented 3 years ago

If you could test with other versions, that would be great. I can't reproduce that on an (older) "normal" arch-kernel. It is possible that the changes in the mentioned commit trigger some driver specific quirks.I As I've said in the other issue, you can also try to narrow down which gl-call actually causes the error.

anriha commented 3 years ago

OK, I added gl_check_err https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L384 and this is the line after which I get the GL_INVALID_FRAMEBUFFER_OPERATION error. I will also test with standard kernel to see it there is any difference.

anriha commented 3 years ago

Tested on normal non zen kernel (still version 5.12.12) the issue persists.

tryone144 commented 3 years ago

Thanks for the testing. Does the error occur if you place the check at the beginning of _gl_compose()? I don't think the the call to glUseProgram() is the one actually failing.

anriha commented 3 years ago

Yeah, something before is failing I still get the same error at the beginning of _gl_compose. I can test other functions. Meanwhile, just to be sure I tested the latest stable release of LTS kernel 5.10.27 and the issue still persists so the kernel is probably not the problem.

tryone144 commented 3 years ago

Can you test _gl_image_decouple() https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L1750 and _gl_image_apply_alpha() https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L1781 please? These get called when frame-opacity != 1, which I can't really test with my i3.

anriha commented 3 years ago

Both of these generate errors https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L1772 and the second one produces error in _gl_fill https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L1054

anriha commented 3 years ago

After some digging i found out that the problem probably begins at https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L1768 if I test it by using glCheckFramebufferStatus I get GL_FRAMEBUFFER_UNSUPPORTED

tryone144 commented 3 years ago

https://github.com/yshui/picom/blob/e09679c7cf454740d9c517bf16625fcdc7466c4b/src/backend/gl/gl_common.c#L1768

if I test it by using glCheckFramebufferStatus I get GL_FRAMEBUFFER_UNSUPPORTED

Can confirm after local testing with xfce4. Maybe we have RGB textures that are not supported by the driver. Have to look into that with more detail.

Edit: The textures in question seem to be in GL_RGBA and GL_BGR with 8 bit per channel with type GL_UNSIGNED_NORMALIZED. Not exactly sure yet why they should fail.

Edit 2: The second fail in _gl_fill() / gl_image_apply_alpha() is most likely just due to the fact the texture hasn't been correctly created in gl_image_decouble() (e.g. size is 0x0).

Edit 3: There seems to be a (driver specific?) problem with attaching textures bound to a glx pixmap to a framebuffer. Creating a new texture with the exact same parameters work fine. However, google didn't come up with anything meaningful for this specific case, so this is just a guess. Maybe someone can test this with amd or intel drivers?

anriha commented 3 years ago

I can test it on my notebook with AMD APU. Should I just test that I get the same error or test something specific?

tryone144 commented 3 years ago

I think checking for the same error (GL_FRAMEBUFFER_UNSUPPORTED) and black windows should be enough.

anriha commented 3 years ago

Can't reproduce on my AMD machine using same configuration. No black windows, no GL_FRAMEBUEFFER_UNSUPPORTED but it is running older version drivers, just to be sure I will update everything and try again.

tryone144 commented 3 years ago

@anriha PR #648 should fix the original problem (on nvidia driver). Can you confirm?

Can't reproduce on my AMD machine using same configuration.

Then it's probably the nvidia driver that doesn't like the textures in question. Sadly opengl doesn't really provide more detailed information about why, the implementation just choose to.

anriha commented 3 years ago

Looks like everything works on https://github.com/yshui/picom/pull/648 no errors and no black windows.

tryone144 commented 3 years ago

Can't reproduce on my AMD machine using same configuration.

I've managed to test https://github.com/yshui/picom/commit/2a60836a9bc30d92b4adb46d5f48684a5d2f1ecb and later on an intel GPU. Can't reproduce the black windows / framebuffer error there either.

    Device: Mesa Intel(R) HD Graphics 5500 (BDW GT2) (0x1616)
    Version: 21.1.3

This hardens the suspicion that it is a problem specific to the (proprietary) nvidia driver.

tryone144 commented 3 years ago

648 has been merged into next.