ysig / GraKeL

A scikit-learn compatible library for graph kernels
https://ysig.github.io/GraKeL/
Other
587 stars 96 forks source link

Add newer python versions to builds #82

Closed eddiebergman closed 1 year ago

eddiebergman commented 1 year ago

I tried to add cp38, cp39, cp310 to the builds.

I moved the coverage and flake8 checks to be on the latest python version.

I also cleaned up the script a tiny bit by removing redundancy, makes it a bit easier to read:

I'm not going to try add windows because I have no way to test this.


Regarding testing it, I guess the easiest way is to create a new branch and I can target the PR to there? I really don't know how.

eddiebergman commented 1 year ago

So I tried my best but the AppVeyor builds fail (even before I modified anything), check out the CI for the most recent commit on the main branch.

I highly advise moving to .github actions, the runners are much more freely available, are free for opensource projects and they support more kinds of runners. It's a lot more maintainable in the long run.

As an example, this one file builds and releases for windows/mac/linux, for different ARM vs intel architectures and linux distributions.

ysig commented 1 year ago

Hi @eddiebergman that's great! If you look at old appveyor commits they fail mainly because of not changing python version (file exists error).

ysig commented 1 year ago

You are all invited to contribute a github actions file and I will be happy to support in any creds or actions needed from my part.