yt-project / widgyts

Widgets for yt
https://widgyts.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 10 forks source link

migrate build system to hatch #107

Closed chrishavlin closed 3 days ago

chrishavlin commented 3 days ago

Running the hatch migration script (see https://hatch-jupyter-builder.readthedocs.io/en/stable/source/how_to_guides/migrating_data_files_projects.html) seemed to work. also, for extra motivation on why migrate, see this post.

Here's the log from running the migration script full_migration_log.txt

After migrating, I can run the examples without a problem (though the screen freezing with the FRB viewing persists for me on firefox).

Running jlpm run build does show some warnings, not sure if they're related to the migration or exposing a pre-existing issue? Will paste the warnings in a comment.

chrishavlin commented 3 days ago

here's the output from running jlpm run build that shows some warnings.

(widgyts_dev) chavlin@deeperthoughts:~/src/yt_general/widgyts_related/widgyts$ jlpm run build
yarn run v1.21.1
$ jlpm run build:lib && jlpm run build:labextension:dev
$ tsc
$ jupyter labextension build --development True .
Building extension in .

Compilation starting…

Compilation finished

assets by chunk 201 KiB (id hint: vendors)
  asset vendors-node_modules_ipycanvas_lib_index_js.dbf81823f316e59217cc.js 182 KiB [emitted] [immutable] (id hint: vendors) 1 related asset
  asset vendors-node_modules_data-exp-lab_yt-tools_yt_tools_js.4e0c1d6caf10cdc04c17.js 19.6 KiB [emitted] [immutable] (id hint: vendors) 1 related asset
asset 281eaf7a360334b1f90d.module.wasm 107 KiB [emitted] [immutable] (auxiliary id hint: vendors)
asset remoteEntry.a0a1814e6e5f131dc5e4.js 35.2 KiB [emitted] [immutable] (name: @yt-project/yt-widgets) 1 related asset
asset lib_colormap_container_js-lib_fixed_res_buffer_js-lib_fullscreen_js-lib_variable_mesh_js-lib_-267046.89a5f2f795f345466681.js 33.5 KiB [emitted] [immutable] 1 related asset
asset style_index_js.7168b29f3b11c6558fc2.js 11.9 KiB [emitted] [immutable] 1 related asset
asset lib_index_js.f227ea1cb2f68e9135a9.js 7.65 KiB [emitted] [immutable] 1 related asset
asset lib_plugin_js.278c2900687e084d357e.js 3.6 KiB [emitted] [immutable] 1 related asset
asset node_modules_fscreen_dist_fscreen_esm_js.4547e652b064a4cf462d.js 3.32 KiB [emitted] [immutable] 1 related asset
runtime modules 24.4 KiB 16 modules
javascript modules 202 KiB 48 modules
consume-shared-module modules 210 bytes
  modules by path consume shared module (default) @jupyter-widgets/ 84 bytes 2 modules
  + 3 modules
provide-module modules 168 bytes
  provide shared module (default) @data-exp-lab/yt-tools@0.4.1 = ./node_modules/@d...(truncated) 42 bytes [built] [code generated]
  provide shared module (default) @yt-project/yt-widgets@0.5.1 = ./lib/index.js 42 bytes [built] [code generated]
  provide shared module (default) fscreen@1.2.0 = ./node_modules/fscreen/dist/...(truncated) 42 bytes [built] [code generated]
  provide shared module (default) ipycanvas@0.8.2 = ./node_modules/ipycanva...(truncated) 42 bytes [built] [code generated]
json modules 4.97 KiB
  ./package.json 3.21 KiB [built] [code generated]
  ./node_modules/ipycanvas/package.json 1.76 KiB [built] [code generated]
./node_modules/@data-exp-lab/yt-tools/yt_tools_bg.wasm 100 bytes (javascript) 107 KiB (webassembly) [built] [code generated]

WARNING in ./node_modules/ipycanvas/lib/index.js
Module Warning (from ./node_modules/source-map-loader/index.js):
(Emitted value instead of an instance of Error) Cannot find SourceMap 'index.js.map': Error: Can't resolve './index.js.map' in '/home/chavlin/src/yt_general/widgyts_related/widgyts/node_modules/ipycanvas/lib'
 @ consume shared module (default) ipycanvas@~0.8.2 (strict) (fallback: ./node_modules/ipycanvas/lib/index.js)
 @ ./lib/widgyts_canvas.js 2:0-52 4:40-51 17:65-88 24:39-49
 @ ./lib/widgyts.js 6:0-33 6:0-33
 @ ./lib/index.js 1:0-26 1:0-26
 @ container entry ./index[0]

WARNING in ./node_modules/ipycanvas/lib/utils.js
Module Warning (from ./node_modules/source-map-loader/index.js):
(Emitted value instead of an instance of Error) Cannot find SourceMap 'utils.js.map': Error: Can't resolve './utils.js.map' in '/home/chavlin/src/yt_general/widgyts_related/widgyts/node_modules/ipycanvas/lib'
 @ ./node_modules/ipycanvas/lib/widget.js 18:16-34
 @ ./node_modules/ipycanvas/lib/index.js 9:9-28
 @ consume shared module (default) ipycanvas@~0.8.2 (strict) (fallback: ./node_modules/ipycanvas/lib/index.js)
 @ ./lib/widgyts_canvas.js 2:0-52 4:40-51 17:65-88 24:39-49
 @ ./lib/widgyts.js 6:0-33 6:0-33
 @ ./lib/index.js 1:0-26 1:0-26
 @ container entry ./index[0]

WARNING in ./node_modules/ipycanvas/lib/version.js
Module Warning (from ./node_modules/source-map-loader/index.js):
(Emitted value instead of an instance of Error) Cannot find SourceMap 'version.js.map': Error: Can't resolve './version.js.map' in '/home/chavlin/src/yt_general/widgyts_related/widgyts/node_modules/ipycanvas/lib'
 @ ./node_modules/ipycanvas/lib/index.js 8:9-29
 @ consume shared module (default) ipycanvas@~0.8.2 (strict) (fallback: ./node_modules/ipycanvas/lib/index.js)
 @ ./lib/widgyts_canvas.js 2:0-52 4:40-51 17:65-88 24:39-49
 @ ./lib/widgyts.js 6:0-33 6:0-33
 @ ./lib/index.js 1:0-26 1:0-26
 @ container entry ./index[0]

WARNING in ./node_modules/ipycanvas/lib/widget.js
Module Warning (from ./node_modules/source-map-loader/index.js):
(Emitted value instead of an instance of Error) Cannot find SourceMap 'widget.js.map': Error: Can't resolve './widget.js.map' in '/home/chavlin/src/yt_general/widgyts_related/widgyts/node_modules/ipycanvas/lib'
 @ ./node_modules/ipycanvas/lib/index.js 9:9-28
 @ consume shared module (default) ipycanvas@~0.8.2 (strict) (fallback: ./node_modules/ipycanvas/lib/index.js)
 @ ./lib/widgyts_canvas.js 2:0-52 4:40-51 17:65-88 24:39-49
 @ ./lib/widgyts.js 6:0-33 6:0-33
 @ ./lib/index.js 1:0-26 1:0-26
 @ container entry ./index[0]

4 warnings have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.95.0 compiled with 4 warnings in 495 ms
Done in 4.62s.
chrishavlin commented 3 days ago

just pushed up some changes to the readme for setting up a dev environment, modified from the cookiecutter at https://github.com/jupyter-widgets/widget-ts-cookiecutter

chrishavlin commented 3 days ago

note: should update the actions since jupyter_packaging should not be needed any more, but installing it shouldnt hurt so i'll let the tests run through for now.