search

yt-project / yt_astro_analysis

yt astrophysical analysis modules
Other
21 stars 21 forks source link

MNT: simplify build dependencies #221

Closed neutrinoceros closed 11 months ago

neutrinoceros commented 11 months ago

Following the release of numpy 1.26, we don't need a special case for CPython 3.12 anymore

neutrinoceros commented 11 months ago

Ah, of course, tests are now failing on CPython 3.8 because yt is always installed from source in CI, and the dev version now requires 3.9 or newer. This is unrelated to the present PR.

@brittonsmith , what would you rather we do ? drop Python 3.8 here too, or start using wheels in (most ?) CI jobs ?

brittonsmith commented 11 months ago

From a practical perspective, it seems unnecessarily difficult to try and support versions of things that yt does not. I'm for staying in sync with yt. Perhaps now is a good time to do a quick release and drop Python 3.8?

neutrinoceros commented 11 months ago

Fine by me. I'll close this in favour of #222 !