search

ytdl-js / react-native-ytdl

A YouTube downloader for React Native
121 stars 46 forks source link

Regarding production build #28

Open ajoykarmakar opened 4 years ago

ajoykarmakar commented 4 years ago

I am using your fantastic library and it's working like a charm but I am little bit concerned about the production release. If YouTube update something from their side, the plugin will work or it will be break down?

Thank & Regards, Ajoy Karmakar

AbelTesfaye commented 4 years ago

Hi! Glad you found this library useful. Unfortunately this library could break if YouTube makes changes to their url deciphering algorithm.

ajoykarmakar commented 4 years ago

Thanks for your response. Can we expect resolve update from this library if anytime it happens?

benkaiser commented 4 years ago

@ajoykarmakar if the past is anything to go off, @AbelTesfaye will get around to it when he has time, but you could be waiting several weeks (he's not being paid to maintain this project). Typically upstream ytdl fixes issues pretty fast so in the event of something going wrong and @AbelTesfaye not having time you can try and port the fix yourself.

AbelTesfaye commented 4 years ago

Thanks for your response. Can we expect resolve update from this library if anytime it happens?

This library should be much easier to port now after the v3.1.1 update. The previous version had changes that could have been avoided, and hence it got a bit complicated to maintain. But the current version has minimal changes hence it shouldn't take a lot of time to port the new patches. As @benkaiser mentioned, I make no promises but I think you can count on me to update this library within a week of when it starts breaking.

lesmo commented 4 years ago

Just curious... is it feasible to automate it somehow?

AbelTesfaye commented 4 years ago

Just curious... is it feasible to automate it somehow?

I've also been thinking of ways to automate the process.The framework independent patches will probably be easiest to integrate. Even some of the methods provided by the node libraries could be polyfilled to work on RN. But after all this it's highly likely there will still be some code the automation tool couldn't merge(or made a buggy merge) and human interaction will still be necessary to go through the code changes.