search

ytorg / Yotter

Youtube and Twitter with privacy.
GNU Affero General Public License v3.0
465 stars 36 forks source link

Resolutions higher than 720p #48

Open FireMasterK opened 3 years ago

FireMasterK commented 3 years ago

Currently, the maximum resolution seems to be 720p?

pluja commented 3 years ago

Yes. This needs some work! I think this shouldn't be hard to address

fromxt commented 3 years ago

Can we automatically select the available dash quality or something like invidious?

pluja commented 3 years ago

Not right now, but I will be working on it.

FireMasterK commented 3 years ago

We should ideally have a quality selector like how newpipe does, including support for webm.

pluja commented 3 years ago

Yes, I think I know how we can do this. I will work on it on the following days.

FireMasterK commented 3 years ago

I did a lot of research on this recently, you'll need to generate a dash manifest for this to even work, otherwise you'll get a video without any audio.

FireMasterK commented 3 years ago

And it will be impossible for clients without javascript to play these streams.

pluja commented 3 years ago

Hm... I see. Thank you! I will leave this issue for now, I am focusing on having everything working fine for now as I have a limited time!

unixfox commented 3 years ago

I'm really interested into this issue. Once this will be implemented I might consider switching https://yewtu.be from Invidious to Yotter.

pluja commented 3 years ago

This needs some work, and I currently don't have any time to code... Maybe in a week or so I will be able to start dedicating time to Yotter and get all these features done.

FireMasterK commented 3 years ago

This is fortunately possible to implement with youtube-dlc. However, from my research, videojs does not support remuxing for WEBM streams.

This is also the reason why invidious only has support for mp4 files. (and it's 50kbps audio bitrate)

You can take a look at https://github.com/GilgusMaximus/yt-dash-manifest-generator to see how it should be done to mp4 files.

This is why I've decided to try to create yet another proxy. One that will mux 2 streams using ffmpeg.

FireMasterK commented 3 years ago

However, I would like some feedback for the hacky fix I made in https://piped.kavin.rocks/, another WIP alternative youtube frontend.

Just tell me what browser you use, if the audio is stuttering during videoplayback, and a log of the numbers you see in your dev tools console.

This has support for WebM streams and uses a similar approach to what cloudtube does.

fadster commented 3 years ago

@FireMasterK I'm not getting any audio on Piped.