#5013 [YCQL] make ycqlsh python3 compatible

yugabyte / cqlsh

Yugabyte Cloud Query Language (YCQL) shell for YugabyteDB database

Apache License 2.0

4 stars 16 forks source link

#5013 [YCQL] make ycqlsh python3 compatible #6

Closed d-uspenskiy closed 4 years ago

d-uspenskiy commented 4 years ago

Applying the following commit from cassandra project

https://github.com/apache/cassandra/commit/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79

to current version of ycqlsh in YB repository (3.10)

Merge was almost trivial with some manual work.

Test plan:

run cqlsh by python2 and python3
run cpp and java tests with new cqlsh ./yb_build.sh --ctest --java-tests

iSignal commented 4 years ago

@d-uspenskiy, could you add some details to the PR message?

Test Plan : did the test script within the cqlsh repo pass for both 2 and 3?
Was it a straightforward port or were there some non trivial changes during the port?

Honestly, there's a lot of changes in there, so probably going to make a best effort pass and accept, unless @mbautin has the time for a more detailed review.

d-uspenskiy commented 4 years ago

@iSignal I've updated the description