search

yujinakayama / atom-lint

Obsolete: Generic code linting support for Atom
https://atom.io/packages/atom-lint
MIT License
111 stars 33 forks source link

How to disable clang warnings? #103

Open whitfier opened 9 years ago

whitfier commented 9 years ago

Sorry if this is a silly question, but looking through the settings, I don't see a place to disable certain warnings.

I am writing in C++11 and would like to disable the -Wc++11-extensions warning. How do I do that if it is possible?

driskell commented 9 years ago

Looks like it used to read .clang-complete file for compiler options like -Wc++11-extensions. But in 0.17.0 it was removed by @yujinakayama (you can see it removed in Change Log) and the documentation says it is temporarily disabled.

When will it return, do we know? Why was it removed (the commit message is vague)?

Be great to get it back. Thanks!

driskell commented 9 years ago

Found the original PR: https://github.com/yujinakayama/atom-lint/pull/70 But seems to be reverted. @yujinakayama are you able to shed some light on it? I know you might be busy but if its something that needs fixing maybe someone can help, and documenting the reason for revert would save us some of the work :-) Thanks! Love the linter btw.

Kev commented 9 years ago

Apologies, this is probably my fault (clang-flags author, the package atom-lint uses to read .clang_complete files, and compdb files to work out per-file clang flags). I didn't keep it sufficiently up to date with Atom changes, and I think that's why it was disabled. Trunk now works again, and I'll look to make a new release of the package with the fixes in when I have a chance. Presumably atom-lint will be able to use clang-flags again.

driskell commented 9 years ago

Hi @Kev - no worries! Thanks for dropping by with an update. I appreciate it's likely the package is maintained in your free time so I'd say there's nothing to apologise, we just need thank you for it's mere existence. Then again, if you are paid, apology accepted, but the thanks still stands ;-)

Kev commented 9 years ago

For what it's worth, I made a new release of clang-flags a few weeks ago. So it could presumably be re-enabled now. I'll try to sort out a PR when I have some spare minutes (I don't have many, so probably not for a while) to re-enable it in atom-lint, if no-one gets there before me.